Skip to content

Review the use of const and @constCast throughout the library #35

@00JCIV00

Description

@00JCIV00

The use of @constCast is generally discouraged, but it's used throughout the library in the Command, Option, and Value types. There two main reasons for this:

  1. A desire to use const as a sort of equivalent to val in Kotlin, wherein the data can be made immutable to external users but still be mutated internally.
  2. A lack of understanding of how const works. Namely, the fact that it applies to memory directly instead of the data or Type. Because of this, the compiler can make assumptions about const data and even choose to move it to the rodata section of a program.

While the library ostensibly works fine in its current state, this is an item that's worth reviewing for completeness down the line.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions