PR comments

Author: flashsturz

firebase/firestore/_utils.py

@@ -10,6 +10,7 @@
 from google.protobuf.json_format import MessageToDict
 from google.cloud.firestore_v1._helpers import GeoPoint
 from google.api_core.datetime_helpers import DatetimeWithNanoseconds
+from google_crc32c import value
 
 
 def _from_datastore(data):
@@ -36,8 +37,6 @@ def _from_datastore(data):
 			else:
 				data_to_restructure[key] = {}
 
-			data_to_restructure[key] = dic
-
 		elif isinstance(val.get('arrayValue'), dict):
 			arr = []
 
@@ -72,32 +71,33 @@ def _decode_datastore(value):
 	:raises TypeError: For value types that are unsupported.
 	"""
 
-	if value.get('nullValue', False) is None:
+	if 'nullValue' in value:
 		return value['nullValue']
 
-	elif value.get('booleanValue') is not None:
+	elif 'booleanValue' in value:
 		return bool(value['booleanValue'])
 
-	elif value.get('bytesValue'):
+	elif 'bytesValue' in value:
 		return b64decode(value['bytesValue'].encode('utf-8'))
 
-	elif value.get('integerValue'):
+	elif 'integerValue' in value:
 		return int(value['integerValue'])
 
-	elif value.get('doubleValue'):
+	elif 'doubleValue' in value:
 		return float(value['doubleValue'])
 
-	elif isinstance(value.get('stringValue'), str) and value.get('stringValue') is not None:
-		return str(value['stringValue'])
+	elif 'stringValue' in value and isinstance(value['stringValue'], str):
+		return value['stringValue']
 
-	elif value.get('mapValue'):
+	elif 'mapValue' in value:
 		return _from_datastore(value['mapValue'])
 
-	elif value.get('timestampValue'):
+	elif 'timestampValue' in value:
 		return DatetimeWithNanoseconds.from_rfc3339(value['timestampValue'])
 
-	elif value.get('geoPointValue'):
-		return GeoPoint(float(value['timestampValue']['latitude']), float(value['timestampValue']['longitude']))
+	elif 'geoPointValue' in value:
+		geo = value['geoPointValue']
+		return GeoPoint(float(geo['latitude']), float(geo['longitude']))
 
 	else:
 		raise TypeError("Cannot convert to a Python Value", value, "Invalid type", type(value))