A warning should tell you if you don't have permission

[a-barbieri]

Issue

Currently if you don't have access to a resource because you forget to give permission to your API user, the query returns an empty array. This leaves you in a total darkness.

Expected behaviour

There should be a warning that informs you what the problem is. This is very helpful whne debugging.

How to reproduce the issue

1. create a new structure for components
2. create a some components
3. run the query below

{
  components_by_structure(structure_slug: "my-new-structure"){
    edges {
      node {
        id
      }
    }
  }
}

As you forgot to update your API user to allow accessing the new structure, the query will not fail but will give you an empty array.

System configuration

Binda API version: v0.2.0.alpha.1

Binda version: 0.1.11

Rails version: 5.2

[Marchino]

That’s by design since we decided not to raise exceptions when we call for wrong fields, for example. We should probably come up with a smart way to report exceptions and use it for everything. On 3 dicembre 2018 a 11:06:07, Alessandro (notifications@github.com) scritto: Issue Currently if you don't have access to a resource because you forget to give permission to your API user, the query returns an empty array. This leaves you in a total darkness. Expected behaviour There should be a warning that informs you what the problem is. This is very helpful whne debugging. How to reproduce the issue 1. create a new structure for components 2. create a some components 3. run the query below { components_by_structure(structure_slug: "my-new-structure"){ edges { node { id } } } } As you forgot to update your API user to allow accessing the new structure, the query will not fail but will give you an empty array. System configuration Binda API version: v0.2.0.alpha.1 Binda version: 0.1.11 Rails version: 5.2 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABG1MiulHqIWUZEoCLkjOZtpoob7Rn3ks5u1PeOgaJpZM4Y-P4Q> .

[a-barbieri]

That’s by design since we decided not to raise exceptions when we call for
wrong fields, for example.

You are right, if I'm not wrong we decided to avoid raising exception because a single exception would brake a query where almost 90% is correct. So returning an empty array would save you from splitting your big query in single smaller ones and letting us doing a single request rather than several.

I think it's time to change this rule. From our experience we have seen is more harmful than useful.

Darkness in debugging is evil.

If you agree we can start a new branch issue#16 to update current queries.

[Marchino]

Totally agree!

…

-- Marco Crepaldi On 3 dicembre 2018 a 11:55:01, Alessandro (notifications@github.com) scritto: That’s by design since we decided not to raise exceptions when we call for wrong fields, for example. You are right, if I'm not wrong we decided to avoid raising exception because a single exception would brake a query where almost 90% is correct. So returning an empty array would save you from splitting your big query in single smaller ones and letting us doing a single request rather than several. I think it's time to change this rule. From our experience we have seen is more harmful than useful. Darkness in debugging is evil. If you agree we can start a new branch issue#16 to update current queries. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABG1JzJsMKm1bHve9hUmi7SnvLDCBkLks5u1QMEgaJpZM4Y-P4Q> .