Faulty histogram computation?

[daso94msg]

Hello,

There are two things that I think are wrong in ydata_profiling/model/summary_algorithms.histogram_compute:

if len(bins) > hist_config.max_bins:
    bins = np.histogram_bin_edges(finite_values, bins=hist_config.max_bins)  
    weights = weights if weights and len(weights) == hist_config.max_bins else None

1. I think it needs to be len(bins) > hist_config.max_bins +1 , as np.histogram_bin_edges includes the rightmost edge, so that its return value will always be number of bins +1.
2. Why are the weights set to None if len(weights) != hist_config.max_bins? The shape of the weights should corespond to the values and will almost never be the same shape as the bins. I can't really think of a reasoning for this check at all.

@alexbarros: I see that you made that commit initially, could you elaborate?

Regards

David

[alexbarros]

You are correct on both cases, I believe this fell under the radar because the conditional len(bins) > hist_config.max_bins is unlikely to trigger, because the user needs to either set the configuration of bins to be higher than max_bins or bins is set to 0 and is automatically detected to be higher than max_bins.

Thanks for pointing it out, and sry for the late reply.
@daso94msg want to create a PR for it?
@fabclmnt can you set the label as bug plz.