chore: Fix clippy warnings

Author: DerekCuevas

src/block.rs

@@ -160,9 +160,7 @@ impl Block {
 
         if block_reward != expected_block_reward {
             return Err(anyhow::anyhow!(
-                "Block reward for coinbase transaction does not match expected block reward: {} != {}",
-                block_reward,
-                expected_block_reward
+                "Block reward for coinbase transaction does not match expected block reward: {block_reward} != {expected_block_reward}"
             ));
         }
 
@@ -264,7 +262,7 @@ mod tests {
         };
 
         let nonce = header.compute_nonce_naive().unwrap();
-        println!("Found Nonce: {}", nonce);
+        println!("Found Nonce: {nonce}");
         header.nonce = nonce;
 
         let hash = header.hash().unwrap();

src/chain.rs

@@ -83,7 +83,7 @@ impl Blockchain {
     }
 
     pub fn get_node(&self, height: u32) -> Option<Arc<BlockchainNode>> {
-        self.nodes.get(&height).map(|node| node.clone())
+        self.nodes.get(&height).cloned()
     }
 
     pub fn contains_node(&self, index: &Arc<BlockchainNode>) -> bool {

src/crypto.rs

@@ -44,7 +44,7 @@ impl SignatureExt for Signature {
         let secp = Secp256k1::verification_only();
         let digest = sha256d(bytes);
         let message = Message::from_digest(digest);
-        secp.verify_ecdsa(message, &self, &public_key).is_ok()
+        secp.verify_ecdsa(message, self, public_key).is_ok()
     }
 }
 
@@ -75,7 +75,7 @@ struct Sha256dHasher {}
 impl rs_merkle::Hasher for Sha256dHasher {
     type Hash = [u8; 32];
     fn hash(data: &[u8]) -> Self::Hash {
-        sha256d(data).into()
+        sha256d(data)
     }
 }
 

src/main.rs

@@ -40,11 +40,11 @@ fn hash_string(input: &str, format: ByteDisplay) {
     let hash = Sha256::digest(input.as_bytes());
 
     match format {
-        ByteDisplay::Hex => println!("Hash (hex): {:#32x}", hash),
+        ByteDisplay::Hex => println!("Hash (hex): {hash:#32x}"),
         ByteDisplay::Base64 => {
             let bytes = hash.to_vec();
             let encoded = base64::engine::general_purpose::STANDARD.encode(bytes);
-            println!("Hash (base64): {}", encoded);
+            println!("Hash (base64): {encoded}");
         }
     }
 }

src/node.rs

@@ -179,7 +179,7 @@ mod tests {
         let keypair_alice = KeyPair::generate();
         let address_alice = Address::from_public_key(&keypair_alice.public_key);
 
-        let coinbase_tx = genesis_block.transactions.get(0).unwrap();
+        let coinbase_tx = genesis_block.transactions.first().unwrap();
 
         let tx_a_body = TransactionBody {
             input: TransactionInput::Reference(coinbase_tx.output_reference(0).unwrap()),

src/transaction.rs

@@ -24,7 +24,7 @@ impl std::fmt::Display for TxId {
 
 impl std::fmt::Debug for TxId {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "TxId({})", self.to_string())
+        write!(f, "TxId({self})")
     }
 }
 
@@ -84,7 +84,7 @@ pub struct SigningInfo {
 impl SigningInfo {
     pub fn sign(keypair: &KeyPair, bytes: &[u8]) -> Self {
         Self {
-            signature: keypair.sign(&bytes),
+            signature: keypair.sign(bytes),
             public_key: keypair.public_key,
         }
     }
@@ -140,10 +140,10 @@ impl Transaction {
             }],
         };
 
-        body.into_tx(&keypair)
+        body.into_tx(keypair)
     }
 
-    pub fn build_merkle_tree(transactions: &Vec<Self>) -> Result<MerkleTree> {
+    pub fn build_merkle_tree(transactions: &[Self]) -> Result<MerkleTree> {
         let tx_ids = transactions
             .iter()
             .map(|tx| tx.id())

src/utxo_set.rs

@@ -17,7 +17,7 @@ impl UTXOSet {
         let TransactionBody { input, outputs } = &transaction.body;
 
         if let TransactionInput::Reference(reference) = input {
-            let removed = self.outputs.remove(&reference);
+            let removed = self.outputs.remove(reference);
             if removed.is_none() {
                 return Err(anyhow::anyhow!("Transaction output reference not found"));
             }