tests: update after refactoring to use new form elements

Author: allison-truhlar

frontend/src/__tests__/componentTests/Browse.test.tsx

@@ -49,8 +49,8 @@ describe('Browse - WelcomeTutorialCard visibility', () => {
     });
 
     const user = userEvent.setup();
-    const checkbox = screen.getByRole('checkbox', { name: /hide this card/i });
-    expect(checkbox).not.toBeChecked();
+    const checkbox = screen.getByRole('checkbox', { name: /show this card/i });
+    expect(checkbox).toBeChecked();
     await user.click(checkbox);
 
     await waitFor(() => {

frontend/src/__tests__/componentTests/WelcomeTutorialCard.test.tsx

@@ -28,33 +28,30 @@ describe('WelcomeTutorialCard', () => {
     });
   });
 
-  it('displays checkbox with correct label and helper text', async () => {
+  it('displays checkbox with correct label', async () => {
     render(<WelcomeTutorialCard />, { initialEntries: ['/browse'] });
 
     await waitFor(() => {
       expect(
-        screen.getByLabelText(/hide this card.*help page/i)
-      ).toBeInTheDocument();
-      expect(
-        screen.getByText(/you can always access tutorials from the help page/i)
+        screen.getByLabelText(/show this card on startup/i)
       ).toBeInTheDocument();
     });
   });
 
   it('checkbox reflects showTutorial preference state', async () => {
     render(<WelcomeTutorialCard />, { initialEntries: ['/browse'] });
 
-    const checkbox = await screen.findByLabelText(/hide this card.*help page/i);
+    const checkbox = await screen.findByLabelText(/show this card on startup/i);
 
-    // showTutorial is true by default, so checkbox should be unchecked (inverse)
-    expect(checkbox).not.toBeChecked();
+    // showTutorial is true by default, so checkbox should be checked
+    expect(checkbox).toBeChecked();
   });
 
   it('toggles preference when checkbox is clicked and shows success toast', async () => {
     render(<WelcomeTutorialCard />, { initialEntries: ['/browse'] });
 
     const user = userEvent.setup();
-    const checkbox = await screen.findByLabelText(/hide this card.*help page/i);
+    const checkbox = await screen.findByLabelText(/show this card on startup/i);
 
     await user.click(checkbox);
 
@@ -78,7 +75,7 @@ describe('WelcomeTutorialCard', () => {
     render(<WelcomeTutorialCard />, { initialEntries: ['/browse'] });
 
     const user = userEvent.setup();
-    const checkbox = await screen.findByLabelText(/hide this card.*help page/i);
+    const checkbox = await screen.findByLabelText(/show this card on startup/i);
 
     await user.click(checkbox);