include colon in the characters prohibited for a filename (#5366)

Author: Fedr

source/MRMesh/MRStringConvert.cpp

@@ -111,7 +111,7 @@ std::string bytesString( size_t size )
 bool hasProhibitedChars( const std::string& line )
 {
     for ( const auto& c : line )
-        if ( c == '?' || c == '*' || c == '/' || c == '\\' || c == '"' || c == '<' || c == '>' )
+        if ( isProhibitedChar( c ) )
             return true;
     return false;
 }
@@ -120,7 +120,7 @@ std::string replaceProhibitedChars( const std::string& line, char replacement /*
 {
     auto res = line;
     for ( auto& c : res )
-        if ( c == '?' || c == '*' || c == '/' || c == '\\' || c == '"' || c == '<' || c == '>' )
+        if ( isProhibitedChar( c ) )
             c = replacement;
     return res;
 }

source/MRMesh/MRStringConvert.h

@@ -81,10 +81,14 @@ std::string utf8string( const std::string & ) = delete;
 /// ...
 [[nodiscard]] MRMESH_API std::string bytesString( size_t size );
 
-/// returns true if line contains any of OS prohibited chars ('?', '*', '/', '\', '"', '<', '>')
+/// returns true if the character is any of OS prohibited chars ('?', '*', '/', '\', '"', '<', '>', ':')
+[[nodiscard]] inline bool isProhibitedChar( char c )
+    { return c == '?' || c == '*' || c == '/' || c == '\\' || c == '"' || c == '<' || c == '>' || c == ':'; }
+
+/// returns true if line contains at least one character (c) for which isProhibitedChar(c)==true
 [[nodiscard]] MRMESH_API bool hasProhibitedChars( const std::string& line );
 
-/// replace OS prohibited chars ('?', '*', '/', '\', '"', '<', '>') with `replacement` char
+/// replace all characters (c), where isProhibitedChar(c)==true, with `replacement` char
 [[nodiscard]] MRMESH_API std::string replaceProhibitedChars( const std::string& line, char replacement = '_' );
 
 /// if (v) contains an error, then appends given file name to that error