Move by Mouse impl customizations (#5369)

* Move by Mouse impl customizations

* add comment

Author: Grantim

source/MRViewer/MRMoveObjectByMouseImpl.cpp

@@ -72,6 +72,7 @@ void MoveObjectByMouseImpl::onDrawDialog() const
     if ( transformMode_ != TransformMode::None )
     {
         auto drawList = ImGui::GetBackgroundDrawList();
+        UI::LineAntialiasingDisabler ds( *drawList );
         drawList->AddPolyline( visualizeVectors_.data(), int( visualizeVectors_.size() ),
                                SceneColors::get( SceneColors::Labels ).getUInt32(), ImDrawFlags_None, 1.f );
     }
@@ -136,19 +137,17 @@ bool MoveObjectByMouseImpl::onMouseDown( MouseButton button, int modifiers )
                 clear_(); // stop mouse dragging if the transformation was changed from outside (e.g. undo)
         } ) );
     }
+    referencePlane_ = calcControlPlane_( viewport, viewportCenterPoint, xfCenterPoint_ );
 
-    if ( transformMode_ == TransformMode::Rotation || transformMode_ == TransformMode::UniformScale || transformMode_ == TransformMode::NonUniformScale )
-    {
-        Line3f centerAxis = viewport.unprojectPixelRay( Vector2f( viewportCenterPoint.x, viewportCenterPoint.y ) );
-        referencePlane_ = Plane3f::fromDirAndPt( centerAxis.d.normalized(), xfCenterPoint_ );
+    Line3f startAxis = viewport.unprojectPixelRay( Vector2f( viewportStartPoint.x, viewportStartPoint.y ) );
 
-        Line3f startAxis = viewport.unprojectPixelRay( Vector2f( viewportStartPoint.x, viewportStartPoint.y ) );
-
-        if ( auto crossPL = intersection( referencePlane_, startAxis ) )
-            worldStartPoint_ = *crossPL;
-        else
-            spdlog::warn( "Bad cross start axis and rotation plane" );
+    if ( auto crossPL = intersection( referencePlane_, startAxis ) )
+        worldStartPoint_ = *crossPL;
+    else
+        spdlog::warn( "Bad cross start axis and control plane" );
 
+    if ( transformMode_ == TransformMode::Rotation || transformMode_ == TransformMode::UniformScale || transformMode_ == TransformMode::NonUniformScale )
+    {
         setVisualizeVectors_( { xfCenterPoint_, worldStartPoint_, xfCenterPoint_, worldStartPoint_ } );
     }
     else // if ( transformMode_ == TransformMode::Translation )
@@ -173,14 +172,14 @@ bool MoveObjectByMouseImpl::onMouseMove( int x, int y )
     auto viewportEnd = viewer.screenToViewport( Vector3f( float( x ), float( y ), 0.f ), viewport.id );
     auto worldEndPoint = viewport.unprojectFromViewportSpace( { viewportEnd.x, viewportEnd.y, viewportStartPointZ_ } );
 
+    auto endAxis = viewport.unprojectPixelRay( Vector2f( viewportEnd.x, viewportEnd.y ) );
+    if ( auto crossPL = intersection( referencePlane_, endAxis ) )
+        worldEndPoint = *crossPL;
+    else
+        spdlog::warn( "Bad cross end axis and control plane" );
+
     if ( transformMode_ == TransformMode::Rotation )
     {
-        auto endAxis = viewport.unprojectPixelRay( Vector2f( viewportEnd.x, viewportEnd.y ) );
-        if ( auto crossPL = intersection( referencePlane_, endAxis ) )
-            worldEndPoint = *crossPL;
-        else
-            spdlog::warn( "Bad cross end axis and rotation plane" );
-
         const Vector3f vectorStart = worldStartPoint_ - xfCenterPoint_;
         const Vector3f vectorEnd = worldEndPoint - xfCenterPoint_;
         const float abSquare = vectorStart.length() * vectorEnd.length();
@@ -199,12 +198,6 @@ bool MoveObjectByMouseImpl::onMouseMove( int x, int y )
     }
     else if ( transformMode_ == TransformMode::UniformScale || transformMode_ == TransformMode::NonUniformScale )
     {
-        auto endAxis = viewport.unprojectPixelRay( Vector2f( viewportEnd.x, viewportEnd.y ) );
-        if ( auto crossPL = intersection( referencePlane_, endAxis ) )
-            worldEndPoint = *crossPL;
-        else
-            spdlog::warn( "Bad cross end axis and rotation plane" );
-
         const Vector3f vectorStart = worldStartPoint_ - xfCenterPoint_;
         const Vector3f vectorEnd = worldEndPoint - xfCenterPoint_;
         scale_ = vectorStart.lengthSq() < 1.0e-7f ? 1.0f :
@@ -341,6 +334,12 @@ void MoveObjectByMouseImpl::setCenterPoint_( const std::vector<std::shared_ptr<O
     centerPoint = box.valid() ? box.center() : Vector3f{};
 }
 
+Plane3f MoveObjectByMouseImpl::calcControlPlane_( const Viewport& vp, const Vector3f& viewportCenterPoint, const Vector3f& xfCenterPoint ) const
+{
+    Line3f centerAxis = vp.unprojectPixelRay( Vector2f( viewportCenterPoint.x, viewportCenterPoint.y ) );
+    return Plane3f::fromDirAndPt( centerAxis.d.normalized(), xfCenterPoint );
+}
+
 Box3f MoveObjectByMouseImpl::getBbox_( const std::vector<std::shared_ptr<Object>>& objects ) const
 {
     Box3f worldBbox;

source/MRViewer/MRMoveObjectByMouseImpl.h

@@ -85,6 +85,10 @@ class MRVIEWER_CLASS MoveObjectByMouseImpl
     /// `centerPoint` - a point that will be used as center of rotation/scaling in world space
     MRVIEWER_API virtual void setCenterPoint_( const std::vector<std::shared_ptr<Object>>& objects, Vector3f& centerPoint ) const;
 
+    /// override this function to customize plane in which all movement will happen
+    /// default: screen plane moved to `xfCenterPoint`
+    MRVIEWER_API virtual Plane3f calcControlPlane_( const Viewport& vp, const Vector3f& viewportCenterPoint, const Vector3f& xfCenterPoint ) const;
+
     /// Helper function to calculate world bounding box for several objects
     /// Note: can be invalid (feature objects give an invalid box etc.)
     MRVIEWER_API Box3f getBbox_( const std::vector<std::shared_ptr<Object>>& objects ) const;