Fix byzantine validator punishment

danil-lashin · danil-lashin · commit 78fbcaec4de4 · 2020-08-28T06:04:03.000+03:00
diff --git a/core/minter/minter.go b/core/minter/minter.go
@@ -220,7 +220,7 @@ func (app *Blockchain) BeginBlock(req abciTypes.RequestBeginBlock) abciTypes.Res
 
 		// skip already offline candidates to prevent double punishing
 		candidate := app.stateDeliver.Candidates.GetCandidateByTendermintAddress(address)
-		if candidate == nil || candidate.Status == candidates.CandidateStatusOffline {
+		if candidate == nil || candidate.Status == candidates.CandidateStatusOffline || app.stateDeliver.Validators.GetByTmAddress(address) == nil {
 			continue
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ func (app *Blockchain) BeginBlock(req abciTypes.RequestBeginBlock) abciTypes.Res`
`220`	`220`
`221`	`221`	`// skip already offline candidates to prevent double punishing`
`222`	`222`	`candidate := app.stateDeliver.Candidates.GetCandidateByTendermintAddress(address)`
`223`		`- if candidate == nil \|\| candidate.Status == candidates.CandidateStatusOffline {`
	`223`	`+ if candidate == nil \|\| candidate.Status == candidates.CandidateStatusOffline \|\| app.stateDeliver.Validators.GetByTmAddress(address) == nil {`
`224`	`224`	`continue`
`225`	`225`	`}`
`226`	`226`