-
Notifications
You must be signed in to change notification settings - Fork 115
BlockTripsWithOverlappingStopTimesNotice error not being caught #1089
Copy link
Copy link
Closed
Labels
GTFS ReferenceUsed for Adding or changing rules that belong in the GTFS referenceUsed for Adding or changing rules that belong in the GTFS referencebugSomething isn't working (crash, a rule has a problem)Something isn't working (crash, a rule has a problem)dependenciesPull requests that update a dependency filePull requests that update a dependency filestatus: Work in progressA PR that would close this issue has been opened.A PR that would close this issue has been opened.
Metadata
Metadata
Assignees
Labels
GTFS ReferenceUsed for Adding or changing rules that belong in the GTFS referenceUsed for Adding or changing rules that belong in the GTFS referencebugSomething isn't working (crash, a rule has a problem)Something isn't working (crash, a rule has a problem)dependenciesPull requests that update a dependency filePull requests that update a dependency filestatus: Work in progressA PR that would close this issue has been opened.A PR that would close this issue has been opened.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Done
Bug report
Describe the bug
Trillium Solutions is building a UI for the gtfs-validator. During our QA process, we encountered a potential bug in which the validator tool doesn't catch overlapping blocks and the
BlockTripsWithOverlappingStopTimesNoticerule doesn't get triggered. We've created a GTFS dataset with purposely "bad" data to test the validator.How we reproduce the bug
Steps to reproduce the behaviour:
(gtfs-validator-test-us.zip).
BlockTripsWithOverlappingStopTimesNoticeerror but not find the error message.Expected behaviour
We would expect the
BlockTripsWithOverlappingStopTimesNoticeerror message to appear with all necessary identifying data points to allow a user to make corrections to the dataset.Observed behaviour
BlockTripsWithOverlappingStopTimesNoticedoesn't appear to be working properly.Screenshots:

Image is from Trillium Solutions GTFS Manager software
There are six block overlaps that our own software is catching but gtfs-validator isn't.
We think investigating this possible bug at this file location would be a good start
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/and adding more test cases here.Environment versions
Please let me know if there's any other info y'all need.