Fix: Guid PKs bulk-inserted as NULL without explicit ValueGeneratedNever() (#105)

* Initial plan

* Fix: include Guid PKs in bulk INSERT by default (unless they have a SQL default/computed expression)

Agent-Logs-Url: https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert/sessions/aa61e1ea-a4c4-4114-857f-cd0d547277d4

Co-authored-by: PhenX <42170+PhenX@users.noreply.github.com>

* Fix: also treat HasDefaultValue() Guid columns as generated; assert Guid ID in merge test

* Fix: use FindAnnotation(RelationalAnnotationNames.DefaultValue) instead of GetDefaultValue() for Guid generated check

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PhenX <42170+PhenX@users.noreply.github.com>

Author: Copilot

src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/ColumnMetadata.cs

@@ -21,7 +21,11 @@ public ColumnMetadata(IProperty property,  SqlDialectBuilder dialect, IComplexPr
         QuotedColumName = dialect.Quote(ColumnName);
         StoreDefinition = GetStoreDefinition(property);
         ClrType = property.ClrType;
-        IsGenerated = property.ValueGenerated != ValueGenerated.Never;
+        IsGenerated = property.ValueGenerated != ValueGenerated.Never
+                      && (property.GetDefaultValueSql() != null
+                          || property.GetComputedColumnSql() != null
+                          || property.FindAnnotation(RelationalAnnotationNames.DefaultValue) != null
+                          || (property.ClrType != typeof(Guid) && property.ClrType != typeof(Guid?)));
     }
 
     private readonly Func<object, object?> _getter;

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestDbContext.cs

@@ -30,12 +30,6 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                 .HasConversion(new DateTimeToBinaryConverter());
         });
 
-        modelBuilder.Entity<TestEntityWithGuidId>(builder =>
-        {
-            builder.Property(e => e.Id)
-                .ValueGeneratedNever();
-        });
-
         modelBuilder.Entity<TestEntityWithComplexType>(builder =>
         {
             builder

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs

@@ -314,15 +314,12 @@ public async Task InsertEntities_WithGeneratedGuidId(InsertStrategy strategy)
             new TestEntityWithGuidId { TestRun = _run, Id = Guid.NewGuid(), Name = $"{_run}_Entity2" }
         };
 
-        // Act
-        var insertedEntities = await _context.InsertWithStrategyAsync(strategy, entities, configure => configure.CopyGeneratedColumns = true);
+        // Act - Guid PKs should be included in INSERT without requiring CopyGeneratedColumns = true
+        var insertedEntities = await _context.InsertWithStrategyAsync(strategy, entities);
 
-        // Assert
+        // Assert - all fields including the application-assigned Guid Id should be preserved
         insertedEntities.Should().BeEquivalentTo(entities,
-            o=> o
-                .RespectingRuntimeTypes()
-                .Excluding(e => e.Id)
-            );
+            o => o.RespectingRuntimeTypes());
     }
 
     [SkippableTheory]

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Merge/MergeTestsBase.cs

@@ -87,9 +87,9 @@ public async Task InsertEntities_MultipleTimes_WithGuidId(InsertStrategy strateg
                 Update = (inserted, excluded) => inserted,
             });
 
-        // Assert
+        // Assert - all fields including the application-assigned Guid Id should be preserved
         insertedEntities.Should().BeEquivalentTo(entities,
-            o => o.RespectingRuntimeTypes().Excluding(e => e.Id));
+            o => o.RespectingRuntimeTypes());
     }
 
     [SkippableTheory]