Merge pull request #245 from Resgrid/develop

RU-T50 Build fix

Author: ucswift

app.config.ts

@@ -170,6 +170,12 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
         ios: {
           deploymentTarget: '18.1',
           useFrameworks: 'static',
+          // Build React Native from source instead of the prebuilt
+          // ReactNativeDependencies.xcframework. The prebuilt core does not
+          // re-export RN's preprocessor macros (RCT_EXTERN, RCT_CONCAT) across
+          // the static-framework module boundary, so RCT_EXPORT_MODULE() fails
+          // to compile in third-party Obj-C modules like @react-native-firebase.
+          buildReactNativeFromSource: true,
         },
       },
     ],

plugins/withWebRTCFrameworkFix.js

@@ -7,14 +7,19 @@ const path = require('path');
  * compatibility with use_frameworks! :linkage => :static (required by
  * @react-native-firebase).
  *
- * Fixes three classes of errors:
+ * Fixes four classes of errors:
  * 1. "include of non-modular header inside framework module" — sets
  *    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES for all pods.
  * 2. "declaration of 'X' must be imported from module 'Y' before it is required"
  *    — adds use_modular_headers! so #import statements resolve correctly across
  *    framework module boundaries.
  * 3. "RCTPromiseRejectBlock must be imported from module 'RNFBApp.RNFBAppModule'"
  *    — patches RNFBMessaging source files to import RNFBAppModule explicitly.
+ * 4. "unknown type name 'RCT_EXTERN'" / "duplicate declaration of method
+ *    'RCT_CONCAT'" in RNFBMessagingModule.m (RCT_EXPORT_MODULE fails to expand)
+ *    — sets $RNFirebaseAsStaticFramework = true so the @react-native-firebase
+ *    pods build as static frameworks, letting React's macro headers resolve
+ *    inside the Firebase module.
  */
 const withWebRTCFrameworkFix = (config) => {
   return withDangerousMod(config, [
@@ -23,6 +28,28 @@ const withWebRTCFrameworkFix = (config) => {
       const podfilePath = path.join(config.modRequest.platformProjectRoot, 'Podfile');
       let contents = fs.readFileSync(podfilePath, 'utf-8');
 
+      // 0. Set $RNFirebaseAsStaticFramework = true at global scope (before any
+      //    target) so the @react-native-firebase pods build as static frameworks.
+      //    Without this, under use_frameworks! :linkage => :static the React
+      //    macro headers (RCT_EXTERN, RCT_CONCAT) don't resolve inside the
+      //    Firebase module and RCT_EXPORT_MODULE() fails to compile.
+      if (!contents.includes('$RNFirebaseAsStaticFramework')) {
+        const fbAnchor = 'prepare_react_native_project!';
+        const fbAnchorIdx = contents.indexOf(fbAnchor);
+        if (fbAnchorIdx === -1) {
+          throw new Error(
+            '[withWebRTCFrameworkFix] Could not find prepare_react_native_project! in Podfile — ' +
+              'cannot place $RNFirebaseAsStaticFramework at global scope.'
+          );
+        }
+        const fbEndOfLine = contents.indexOf('\n', fbAnchorIdx);
+        const fbInsertAt = fbEndOfLine === -1 ? contents.length : fbEndOfLine + 1;
+        contents =
+          contents.slice(0, fbInsertAt) +
+          '\n$RNFirebaseAsStaticFramework = true\n' +
+          contents.slice(fbInsertAt);
+      }
+
       // 1. Add use_modular_headers! after use_frameworks! if not already present.
       if (!contents.includes('use_modular_headers!')) {
         const useFrameworksPattern = /use_frameworks!.*\n/g;