Skip to content

Commit 7de5d16

Browse files
committed
fix(hardcover): remove unused reference to edition description
1 parent c9c43ee commit 7de5d16

5 files changed

Lines changed: 2 additions & 11 deletions

File tree

.calibre/Taskfile.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ vars:
55
CALIBRE_LIBRARY: "library"
66
CALIBRE_TEMP: "temp"
77
CALIBRE_SOURCE: "source"
8-
CALIBRE_VERSION: "8.3.0"
8+
CALIBRE_VERSION: "8.5.0"
99

1010
tasks:
1111
clean:

plugins/hardcover/src/hardcover/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
from queue import Empty, Queue
2-
from typing_extensions import override
32

43
from calibre.ebooks.metadata.sources.base import Option, Source
54

@@ -59,11 +58,9 @@ def __init__(self, *args, **kwargs):
5958
self.provider = HardcoverProvider(self)
6059
self.cli_helper = MetadataCliHelper(self, self.name, self.ID_NAME)
6160

62-
@override
6361
def is_configured(self) -> bool: # pyright: ignore[reportIncompatibleMethodOverride]
6462
return bool(self.prefs["api_key"])
6563

66-
@override
6764
def cli_main(self, args):
6865
self.cli_helper.run(args)
6966

@@ -78,11 +75,9 @@ def get_cached_cover_url(self, identifiers):
7875
url = self.cached_identifier_to_cover_url(hardcover_id)
7976
return url
8077

81-
@override
8278
def get_book_url(self, identifiers): # pyright: ignore[reportIncompatibleMethodOverride]
8379
return self.provider.get_book_url(identifiers)
8480

85-
@override
8681
def identify(
8782
self,
8883
log,
@@ -97,7 +92,6 @@ def identify(
9792
log, result_queue, abort, title, authors, identifiers, timeout
9893
)
9994

100-
@override
10195
def download_cover(
10296
self,
10397
log,

plugins/hardcover/src/hardcover/identifier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def _execute(self, query: str, variables: Optional[dict] = None) -> List[Book]:
145145
result: List[Book] = []
146146
key = list(res.keys())[0]
147147

148-
entries = res.get(key) if isinstance(res.get(key), list) else [res.get(key)]
148+
entries = res.get(key, []) if isinstance(res.get(key), list) else [res.get(key)]
149149
for entry in entries:
150150
if key == "books":
151151
result.append(map_from_book_query(entry))

plugins/hardcover/src/hardcover/models.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ class Edition:
2020
language: str
2121
publisher: Optional[str]
2222
release_date: Optional[datetime]
23-
description: Optional[str]
2423

2524

2625
@dataclass
@@ -80,7 +79,6 @@ def map_edition_data(data: dict[str, Any]) -> Edition:
8079
release_date=datetime.strptime(data["release_date"], "%Y-%m-%d")
8180
if data["release_date"]
8281
else None,
83-
description=data.get("description"),
8482
)
8583

8684

plugins/hardcover/src/hardcover/queries.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
name
2323
}
2424
release_date
25-
description
2625
}
2726
2827
fragment BookData on books {

0 commit comments

Comments
 (0)