fix: division by zero if there are no authors

RobBrazier · RobBrazier · commit b674d21054f4 · 2025-09-25T18:46:25.000+01:00
diff --git a/plugins/hardcover/src/hardcover/identifier.py b/plugins/hardcover/src/hardcover/identifier.py
@@ -149,7 +149,9 @@ def _filter_editions_by_author(
                         f"weighted similarity between {authors} and {edition_author}: {weighted_similarity}"
                     )
                     total_similarity += weighted_similarity
-                similarity = total_similarity / len(edition_authors)
+                similarity = 0.0
+                if edition_authors:
+                    similarity = total_similarity / len(edition_authors)
                 self.log.debug(
                     f"overall similarity for {edition.title} ({edition.id}): {similarity}"
                 )

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,9 @@ def _filter_editions_by_author(`
`149`	`149`	`f"weighted similarity between {authors} and {edition_author}: {weighted_similarity}"`
`150`	`150`	`)`
`151`	`151`	`total_similarity += weighted_similarity`
`152`		`- similarity = total_similarity / len(edition_authors)`
	`152`	`+ similarity = 0.0`
	`153`	`+ if edition_authors:`
	`154`	`+ similarity = total_similarity / len(edition_authors)`
`153`	`155`	`self.log.debug(`
`154`	`156`	`f"overall similarity for {edition.title} ({edition.id}): {similarity}"`
`155`	`157`	`)`