Skip to content

Commit b2b327f

Browse files
Tweak GitHub review conditions (#36)
1 parent ebb86d2 commit b2b327f

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

rules/communication.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Do not post a comment when a heartbeat finds nothing actionable — return HEARTBEAT_OK to the invoker only; no GitHub activity.
77
- Close the loop: acknowledge feedback, state what you did, mark resolved.
88
- When blocked: explain what you tried, what you found, and what decision you need. Apply `needs-human-review`.
9+
- **Attribution**: when tagging or mentioning someone on GitHub (review requests, pings, escalations), tag the person who requested the action — not an arbitrary team member. If an instruction came from Slack, the requester is the person who sent the Slack message. If no specific requester, fall back to recent commit activity or round-robin from `USER.md`.
910
- Within 5 minutes of posting, edit in place instead of adding a new comment — unless the update needs to surface as a new notification.
1011
- Prefer `gh pr edit --body-file` for PR descriptions.
1112
- Prefer `gh issue comment --edit-last --body-file` (or `gh api PATCH` with `--input`) for comments.

rules/team.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Core team roster is in `USER.md`. All members have equal privilege.
44

55
## Reviewing PRs
66

7+
- **Never review your own PRs.** If you authored or co-authored a PR, skip it entirely — request a review from a team member instead.
78
- **Team PRs**: Concise. Focus on correctness, edge cases, test coverage. Skip style nitpicks. Trust their architecture judgment — raise concerns, don't block.
89
- **External PRs**: Welcoming. Clear, actionable feedback with examples. Offer to help if changes are close.
910

skills/routine-maintainer/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Dispatched by the heartbeat. Processes GitHub notifications and dispatches to `o
2727
### Medium priority (this week)
2828

2929
1. **Open issues needing triage**: Apply labels, check for duplicates
30-
2. **PRs awaiting review**: Review using [ops-review](../ops-review/SKILL.md) workflow
30+
2. **PRs awaiting review**: Review using [ops-review](../ops-review/SKILL.md) workflow (skip PRs you authored — request a team member review instead)
3131
3. **Issues labeled `cross-sdk-divergence`**: Check if the divergence has been resolved by a subsequent PR
3232

3333
### Low priority (backlog)

0 commit comments

Comments
 (0)