SOLR-18139: Migrate away from Collections.empty*() methods. (#4168)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: epugh

build-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java

@@ -25,7 +25,6 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Set;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import javax.lang.model.element.Element;
 import javax.lang.model.element.ElementKind;
@@ -65,8 +64,8 @@ public class MissingDoclet extends StandardDoclet {
   DocletEnvironment docEnv;
   DocTrees docTrees;
   Elements elementUtils;
-  Set<String> ignored = Collections.emptySet();
-  Set<String> methodPackages = Collections.emptySet();
+  Set<String> ignored = Set.of();
+  Set<String> methodPackages = Set.of();
 
   @Override
   public Set<Doclet.Option> getSupportedOptions() {
@@ -373,7 +372,7 @@ private Stream<Element> superTypeForInheritDoc(Element type) {
         clazz.getInterfaces().stream()
             .filter(tm -> tm.getKind() == TypeKind.DECLARED)
             .map(tm -> ((DeclaredType) tm).asElement())
-            .collect(Collectors.toList());
+            .toList();
 
     Stream<Element> result = interfaces.stream();
     result = Stream.concat(result, interfaces.stream().flatMap(this::superTypeForInheritDoc));

gradle/validation/forbidden-apis/defaults.all.txt

@@ -54,6 +54,15 @@ java.io.File#delete() @ use Files.delete for real exception, IOUtils.deleteFiles
 
 java.util.Collections#shuffle(java.util.List) @ Use shuffle(List, Random) instead so that it can be reproduced
 
+@defaultMessage Use List.of()
+java.util.Collections#emptyList()
+
+@defaultMessage Use Set.of()
+java.util.Collections#emptySet()
+
+@defaultMessage Use Map.of()
+java.util.Collections#emptyMap()
+
 java.util.Locale#forLanguageTag(java.lang.String) @ use new Locale.Builder().setLanguageTag(...).build() which has error handling
 java.util.Locale#toString() @ use Locale#toLanguageTag() for a standardized BCP47 locale name
 
@@ -102,4 +111,4 @@ java.nio.file.Paths#get(**)
 java.nio.file.Path#startsWith(java.lang.String)
 
 @defaultMessage Use NIO Path instead of File
-java.io.File
+java.io.File

solr/benchmark/src/java/org/apache/solr/bench/generators/RandomDataHistogram.java

@@ -23,7 +23,6 @@
 import java.math.RoundingMode;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Locale;
@@ -509,7 +508,7 @@ public String print(boolean sortByLabel, int bucketed) {
                       }
                       return Integer.compare(e2.getValue().get(), e1.getValue().get());
                     })
-                .filter(entry -> !entry.getKey().equals(Collections.emptyList()))
+                .filter(entry -> !entry.getKey().equals(List.of()))
                 .map(
                     entry -> {
                       double percentage = entry.getValue().get() * 100.0 / sum;

solr/core/src/java/org/apache/solr/api/ApiBag.java

@@ -75,13 +75,13 @@ public ApiBag(boolean isCoreSpecific) {
   public synchronized List<Api> registerObject(Object o) {
     List<Api> l = AnnotatedApi.getApis(o);
     for (Api api : l) {
-      register(api, Collections.emptyMap());
+      register(api, Map.of());
     }
     return l;
   }
 
   public synchronized void register(Api api) {
-    register(api, Collections.emptyMap());
+    register(api, Map.of());
   }
 
   public synchronized void register(Api api, Map<String, String> nameSubstitutes) {

solr/core/src/java/org/apache/solr/api/ApiSupport.java

@@ -18,7 +18,7 @@
 package org.apache.solr.api;
 
 import java.util.Collection;
-import java.util.Collections;
+import java.util.Set;
 
 /** The interface that is implemented by a request handler to support the V2 end point */
 public interface ApiSupport {
@@ -36,7 +36,7 @@ public interface ApiSupport {
    * @see #getApis()
    */
   default Collection<Class<? extends JerseyResource>> getJerseyResources() {
-    return Collections.emptySet();
+    return Set.of();
   }
 
   /** Whether this should be made available at the regular legacy path */

solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java

@@ -31,7 +31,6 @@
 import java.lang.reflect.ParameterizedType;
 import java.lang.reflect.Type;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -424,7 +423,7 @@ public void init() throws Exception {
         throw new RuntimeException("Must have a no-arg constructor or CoreContainer constructor ");
       }
       Map<String, Object> config =
-          (Map<String, Object>) holder.original.getOrDefault("config", Collections.emptyMap());
+          (Map<String, Object>) holder.original.getOrDefault("config", Map.of());
       configure(instance, config, holder.meta);
       if (instance instanceof ResourceLoaderAware) {
         try {

solr/core/src/java/org/apache/solr/api/V2HttpCall.java

@@ -29,7 +29,6 @@
 import java.io.IOException;
 import java.lang.invoke.MethodHandles;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.LinkedHashMap;
@@ -488,7 +487,7 @@ private String computeEndpointPath() {
     // myColName -> collection
     final Map<String, String> pathTemplateValKey;
     if (pathTemplateKeyVal.isEmpty()) { // typical
-      pathTemplateValKey = Collections.emptyMap();
+      pathTemplateValKey = Map.of();
     } else if (pathTemplateKeyVal.size() == 1) { // typical
       Map.Entry<String, String> entry = pathTemplateKeyVal.entrySet().iterator().next();
       pathTemplateValKey = Map.of(entry.getValue(), entry.getKey());

solr/core/src/java/org/apache/solr/cloud/CloudUtil.java

@@ -18,7 +18,6 @@
 
 import java.io.IOException;
 import java.lang.invoke.MethodHandles;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -136,7 +135,7 @@ public static Map<String, byte[]> getTrustedKeys(SolrZkClient zk, String dir) {
       }
     } catch (KeeperException.NoNodeException e) {
       log.info("Error fetching key names");
-      return Collections.emptyMap();
+      return Map.of();
     } catch (InterruptedException e) {
       Thread.currentThread().interrupt();
       throw new SolrException(ErrorCode.SERVER_ERROR, "Unable to read crypto keys", e);

solr/core/src/java/org/apache/solr/cloud/DistributedClusterStateUpdater.java

@@ -26,6 +26,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 import org.apache.solr.client.solrj.cloud.SolrCloudManager;
@@ -387,7 +388,7 @@ private void applyUpdate() throws KeeperException, InterruptedException {
       // For now trying to diverge as little as possible from existing data structures and code
       // given the need to support both the old way (Overseer) and new way (distributed) of handling
       // cluster state update.
-      final Set<String> liveNodes = Collections.emptySet();
+      final Set<String> liveNodes = Set.of();
 
       // Per Replica States updates are done before all other updates and not subject to the number
       // of attempts of CAS made here, given they have their own CAS strategy and implementation
@@ -412,7 +413,7 @@ private void applyUpdate() throws KeeperException, InterruptedException {
         // state. Knowing about all collections in the cluster might not be needed.
         ClusterState initialClusterState;
         if (updater.isCollectionCreation()) {
-          initialClusterState = new ClusterState(liveNodes, Collections.emptyMap());
+          initialClusterState = new ClusterState(liveNodes, Map.of());
         } else {
           // Get the state for existing data in ZK (and if no data exists we should fail)
           initialClusterState = fetchStateForCollection();
@@ -586,7 +587,7 @@ private ClusterState fetchStateForCollection() throws KeeperException, Interrupt
           ZkClientClusterStateProvider.createFromJsonSupportingLegacyConfigName(
               stat.getVersion(),
               data,
-              Collections.emptySet(),
+              Set.of(),
               updater.getCollectionName(),
               zkStateReader.getZkClient(),
               Instant.ofEpochMilli(stat.getCtime()));

solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java

@@ -234,7 +234,7 @@ public Map<String, Object> getConfigMetadata(String configName) throws IOExcepti
               Utils.fromJSON(zkClient.getData(CONFIGS_ZKNODE + "/" + configName, null, null));
       return data;
     } catch (KeeperException.NoNodeException e) {
-      return Collections.emptyMap();
+      return Map.of();
     } catch (KeeperException | InterruptedException e) {
       throw new IOException("Error getting config metadata", SolrZkClient.checkInterrupted(e));
     }
@@ -261,7 +261,7 @@ public List<String> listConfigs() throws IOException {
     try {
       return zkClient.getChildren(CONFIGS_ZKNODE, null);
     } catch (KeeperException.NoNodeException e) {
-      return Collections.emptyList();
+      return List.of();
     } catch (KeeperException | InterruptedException e) {
       throw new IOException("Error listing configs", SolrZkClient.checkInterrupted(e));
     }