Skip to content

Have the deviation threshold be specified in percentage #14

@bbenligiray

Description

@bbenligiray

Currently, computeSponsorWalletAddress() expects deviationThreshold to be specified in "normalized percentages". For example, if the user wants to get the sponsor wallet address for 0.5% deviation threshold, they need to set deviationThreshold to be 0.5 * 1e6 = 500000 (https://github.com/nodaryio/examples/blob/main/scripts/get-sponsor-wallet-addresses.js#L16). The normalization method is an implementation detail that shouldn't be exposed to the user, the user should just call the function with 0.5.

This requires a major release, and https://github.com/nodaryio/examples and the manager-multisig will also need to be updated

Metadata

Metadata

Assignees

Labels

NodaryTo be present on the project Nodary API board

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions