Fix version endpoint in packaged image

Author: shuchenliu

src/nameres/handlers/version.py

@@ -1,36 +1,10 @@
-import logging
-import pathlib
-import git
-
 from nameres.handlers.base import NameResolutionBaseHandler
-
-logger = logging.getLogger(__name__)
+from nameres.version import get_version
 
 
 class VersionHandler(NameResolutionBaseHandler):
     name = "version"
 
-    def get_github_commit_hash(self):
-        """Retrieve the current GitHub commit hash using gitpython."""
-        try:
-            # Resolve the absolute path to the current file
-            file_path = pathlib.Path(__file__).resolve()
-
-            # Use git.Repo to find the root of the repository
-            repo = git.Repo(file_path, search_parent_directories=True)
-
-            if repo.bare:
-                # Get the absolute path to the repository root
-                repo_dir = repo.working_tree_dir
-                logger.error(f"Git repository not found in directory: {repo_dir}")
-                return "Unknown"
-
-            commit_hash = repo.head.commit.hexsha  # Get the latest commit hash
-            return commit_hash
-        except Exception as e:
-            logger.error(f"Error getting GitHub commit hash: {e}")
-            return "Unknown"
-
     async def get(self, *args, **kwargs):
-        version = self.get_github_commit_hash()
+        version = get_version()
         self.write({"version": version})

src/nameres/version.py

@@ -0,0 +1,54 @@
+import logging
+import os
+import pathlib
+from collections.abc import Iterable
+
+import git
+
+logger = logging.getLogger(__name__)
+
+UNKNOWN_VERSION = "Unknown"
+VERSION_FILE_NAME = "version.txt"
+VERSION_FILE_ENV_VAR = "NAMERES_VERSION_FILE"
+CONTAINER_VERSION_FILE = pathlib.Path("/home/nameres/configuration") / VERSION_FILE_NAME
+
+
+def read_version_file(version_file_paths: Iterable[pathlib.Path] | None = None) -> str | None:
+    """Read the build-time version file when the app is running from a packaged image."""
+    candidate_paths = []
+    configured_path = os.getenv(VERSION_FILE_ENV_VAR)
+    if configured_path:
+        candidate_paths.append(pathlib.Path(configured_path))
+
+    candidate_paths.extend(version_file_paths or [pathlib.Path.cwd() / VERSION_FILE_NAME, CONTAINER_VERSION_FILE])
+
+    for version_file_path in candidate_paths:
+        try:
+            version = version_file_path.read_text(encoding="utf-8").strip()
+        except OSError:
+            continue
+
+        if version:
+            return version
+
+    return None
+
+
+def get_github_commit_hash(source_path: pathlib.Path | None = None) -> str:
+    """Retrieve the current GitHub commit hash using gitpython."""
+    try:
+        repo_path = source_path or pathlib.Path(__file__).resolve()
+        repo = git.Repo(repo_path, search_parent_directories=True)
+
+        if repo.bare:
+            logger.error("Git repository not found in directory: %s", repo.working_tree_dir)
+            return UNKNOWN_VERSION
+
+        return repo.head.commit.hexsha
+    except Exception as exc:
+        logger.error("Error getting GitHub commit hash: %s", exc)
+        return UNKNOWN_VERSION
+
+
+def get_version() -> str:
+    return read_version_file() or get_github_commit_hash()

test/test_version.py

@@ -0,0 +1,43 @@
+import pytest
+
+from nameres import version as nameres_version
+
+
+def test_read_version_file_uses_configured_path(tmp_path, monkeypatch):
+    configured_version_file = tmp_path / "configured-version.txt"
+    configured_version_file.write_text("configured-sha\n", encoding="utf-8")
+    fallback_version_file = tmp_path / "version.txt"
+    fallback_version_file.write_text("fallback-sha\n", encoding="utf-8")
+
+    monkeypatch.setenv(nameres_version.VERSION_FILE_ENV_VAR, str(configured_version_file))
+
+    assert nameres_version.read_version_file([fallback_version_file]) == "configured-sha"
+
+
+def test_read_version_file_ignores_missing_and_blank_files(tmp_path, monkeypatch):
+    blank_version_file = tmp_path / "blank-version.txt"
+    blank_version_file.write_text("\n", encoding="utf-8")
+    version_file = tmp_path / "version.txt"
+    version_file.write_text("build-sha\n", encoding="utf-8")
+
+    monkeypatch.delenv(nameres_version.VERSION_FILE_ENV_VAR, raising=False)
+
+    assert nameres_version.read_version_file([tmp_path / "missing.txt", blank_version_file, version_file]) == "build-sha"
+
+
+def test_get_version_prefers_build_version_file(monkeypatch):
+    monkeypatch.setattr(nameres_version, "read_version_file", lambda: "build-sha")
+    monkeypatch.setattr(
+        nameres_version,
+        "get_github_commit_hash",
+        lambda: pytest.fail("Git fallback should not run when a build version file exists"),
+    )
+
+    assert nameres_version.get_version() == "build-sha"
+
+
+def test_get_version_falls_back_to_git(monkeypatch):
+    monkeypatch.setattr(nameres_version, "read_version_file", lambda: None)
+    monkeypatch.setattr(nameres_version, "get_github_commit_hash", lambda: "git-sha")
+
+    assert nameres_version.get_version() == "git-sha"