Skip to content

Commit dddefc8

Browse files
authored
fix: correctly determine arch (#6609)
1 parent 0da71e3 commit dddefc8

28 files changed

Lines changed: 30 additions & 31 deletions

src/usr/local/containerbase/tools/v2/git-lfs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function install_tool () {
1111
local lfs_file
1212
local strip=0
1313

14-
if [[ "$(uname -p)" = "aarch64" ]]; then
14+
if [[ "${ARCHITECTURE}" = "aarch64" ]]; then
1515
arch=linux-arm64
1616
fi
1717

src/usr/local/containerbase/tools/v2/jb.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ function install_tool () {
44
local versioned_tool_path
55
local file
66
local arch=linux-amd64
7-
if [[ "$(uname -p)" = "aarch64" ]]; then
7+
if [[ "${ARCHITECTURE}" = "aarch64" ]]; then
88
arch=linux-arm64
99
fi
1010

src/usr/local/containerbase/tools/v2/powershell.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function install_tool () {
1919
local versioned_tool_path
2020
local arch=linux-x64
2121

22-
if [[ "$(uname -p)" = "aarch64" ]]; then
22+
if [[ "${ARCHITECTURE}" = "aarch64" ]]; then
2323
arch=linux-arm64
2424
fi
2525

src/usr/local/containerbase/tools/v2/ruby.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function init_tool () {
7777
}
7878

7979
function install_tool () {
80-
local arch
80+
local arch=${ARCHITECTURE}
8181
local base_url
8282
local checksum_file
8383
local expected_checksum
@@ -90,7 +90,6 @@ function install_tool () {
9090

9191
tool_path=$(find_tool_path)
9292

93-
arch=$(uname -p)
9493
base_url="https://github.com/containerbase/${name}-prebuild/releases/download"
9594
version_codename=$(get_distro)
9695

src/usr/local/containerbase/tools/v2/rust.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,13 @@ function check_tool_requirements () {
3535
function install_tool () {
3636
local versioned_tool_path
3737
local file
38-
local arch
38+
local arch=${ARCHITECTURE}
3939
local base_url
4040
local checksum_file
4141
local expected_checksum
4242
local ext=gz
4343
local file_name
4444

45-
arch=$(uname -p)
4645
file_name="rust-${TOOL_VERSION}-${arch}-unknown-linux-gnu.tar"
4746
base_url="https://static.rust-lang.org/dist/${file_name}"
4847

src/usr/local/containerbase/tools/v2/terraform.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function install_tool () {
55
local file
66
local arch=linux_amd64
77

8-
if [[ "$(uname -p)" = "aarch64" ]]; then
8+
if [[ "${ARCHITECTURE}" = "aarch64" ]]; then
99
arch=linux_arm64
1010
fi
1111

src/usr/local/containerbase/tools/v2/vendir.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function install_tool () {
55
local file
66
local arch=linux-amd64
77

8-
if [[ "$(uname -p)" = "aarch64" ]]; then
8+
if [[ "${ARCHITECTURE}" = "aarch64" ]]; then
99
arch=linux-arm64
1010
fi
1111

src/usr/local/containerbase/utils/constants.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ export CONTAINERBASE_DIR=/usr/local/containerbase
3232
export CONTAINERBASE_VAR_DIR=/var/lib/containerbase
3333
export CONTAINERBASE_TMP_DIR=/tmp/containerbase
3434

35-
# Used to find matching tool downloads
36-
ARCHITECTURE=$(uname -p)
35+
# Used to find matching tool downloads.
36+
# `arch` is preinstalled on ubuntu.
37+
ARCHITECTURE=$(arch)
3738
export ARCHITECTURE
3839

3940
# Used in util.sh and others.

test/Dockerfile.distro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ RUN install-tool git v2.54.0
3232
#--------------------------------------
3333
FROM base AS build
3434

35-
RUN uname -p | tee | grep x86_64
35+
RUN arch | tee | grep x86_64
3636

3737
RUN touch /.dummy
3838

test/dart/Dockerfile.arm64

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ RUN install-containerbase
2424
#--------------------------------------
2525
FROM ${BASE_IMAGE} AS base
2626

27-
RUN uname -p | tee | grep aarch64
27+
RUN arch | tee | grep aarch64
2828
RUN touch /.dummy
2929

3030
ARG APT_HTTP_PROXY

0 commit comments

Comments
 (0)