Skip to content

Commit 266838c

Browse files
test: update smoke test comments to reflect grpcAddress env var
Agent-Logs-Url: https://github.com/crispthinking/athena-nodejs-client/sessions/23f71223-381c-4f55-ad6f-1f2fcb4d9846 Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
1 parent a0a07d1 commit 266838c

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

__tests__/functional/main.functional.test.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ describe('ClassifierSdk Functional Tests', () => {
1414
it('should listDeployments and return responses (smoke test)', async ({
1515
expect,
1616
}) => {
17-
// This is a smoke test. You must have a running gRPC server at localhost:50051 for this to pass.
17+
// This is a smoke test. The gRPC server address is taken from VITE_ATHENA_GRPC_ADDRESS,
18+
// falling back to the SDK default if the variable is not set.
1819
// You may want to mock the gRPC client for true unit testing.
1920
const sdk = new ClassifierSdk({
2021
deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID,
@@ -73,7 +74,8 @@ describe('ClassifierSdk Functional Tests', () => {
7374
expect,
7475
annotate,
7576
}) => {
76-
// This is a smoke test. You must have a running gRPC server at localhost:50051 for this to pass.
77+
// This is a smoke test. The gRPC server address is taken from VITE_ATHENA_GRPC_ADDRESS,
78+
// falling back to the SDK default if the variable is not set.
7779
// You may want to mock the gRPC client for true unit testing.
7880
const imagePath = __dirname + '/448x448.jpg';
7981
const sdk = new ClassifierSdk({
@@ -256,7 +258,8 @@ describe('ClassifierSdk Functional Tests', () => {
256258
expect,
257259
annotate,
258260
}) => {
259-
// This is a smoke test. You must have a running gRPC server at localhost:50051 for this to pass.
261+
// This is a smoke test. The gRPC server address is taken from VITE_ATHENA_GRPC_ADDRESS,
262+
// falling back to the SDK default if the variable is not set.
260263
// You may want to mock the gRPC client for true unit testing.
261264
const imagePath = __dirname + '/448x448.jpg';
262265
const sdk = new ClassifierSdk({

0 commit comments

Comments
 (0)