Refactor transcoding service integration in audio playback

Author: dddevid

lib/main.dart

@@ -218,15 +218,18 @@ void main() async {
   // is ready and fully decoupled from the Flutter widget lifecycle on iOS.
   final audioHandler = await initAudioService();
 
+  // Create TranscodingService instance to share across providers
+  final transcodingService = TranscodingService();
+
   final Widget appWithProviders = MultiProvider(
     providers: [
       Provider<StorageService>.value(value: storageService),
       Provider<SubsonicService>.value(value: subsonicService),
       ChangeNotifierProvider<RecommendationService>.value(
         value: recommendationService,
       ),
-      ChangeNotifierProvider<TranscodingService>(
-        create: (_) => TranscodingService(),
+      ChangeNotifierProvider<TranscodingService>.value(
+        value: transcodingService,
       ),
       ChangeNotifierProvider<LocalMusicService>.value(value: localMusicService),
       ChangeNotifierProvider(
@@ -248,6 +251,7 @@ void main() async {
           upnpService,
           audioHandler,
           jukeboxService,
+          transcodingService,
         ),
       ),
       ChangeNotifierProvider(create: (_) => LibraryProvider(subsonicService)),

lib/providers/player_provider.dart

@@ -29,6 +29,7 @@ import '../services/jukebox_service.dart';
 import '../services/audio_handler.dart';
 import '../services/fade_settings_service.dart';
 import '../services/lock_screen_lyrics_service.dart';
+import '../services/transcoding_service.dart';
 import '../providers/library_provider.dart';
 
 enum RepeatMode { off, all, one }
@@ -103,6 +104,7 @@ class PlayerProvider extends ChangeNotifier with WidgetsBindingObserver {
   bool _isFading = false;
 
   final JukeboxService _jukeboxService;
+  final TranscodingService _transcodingService;
 
   double _playbackSpeed = 1.0;
   double _pitch = 1.0;
@@ -115,6 +117,7 @@ class PlayerProvider extends ChangeNotifier with WidgetsBindingObserver {
     this._upnpService,
     this._audioHandler,
     this._jukeboxService,
+    this._transcodingService,
   ) {
     _storageService = storageService;
     _discordRpcService = DiscordRpcService(storageService);
@@ -1593,7 +1596,15 @@ class PlayerProvider extends ChangeNotifier with WidgetsBindingObserver {
             if (offlinePath != null) {
               playUrl = 'file://$offlinePath';
             } else {
-              playUrl = await _subsonicService.resolveStreamUrlAsync(song);
+              // Apply transcoding settings if enabled
+              final maxBitRate = _transcodingService.enabled
+                  ? _transcodingService.currentBitRate
+                  : null;
+              final format = _transcodingService.enabled
+                  ? _transcodingService.format
+                  : null;
+              playUrl = _subsonicService.getStreamUrl(song.id,
+                  maxBitRate: maxBitRate, format: format);
             }
           }
           // Cache remote streams locally so seeking works even when the
@@ -2388,7 +2399,13 @@ class PlayerProvider extends ChangeNotifier with WidgetsBindingObserver {
     if (offlinePath != null) {
       return AudioSource.uri(Uri.file(offlinePath));
     }
-    final url = _subsonicService.getStreamUrl(song.id);
+    // Apply transcoding settings if enabled
+    final maxBitRate =
+        _transcodingService.enabled ? _transcodingService.currentBitRate : null;
+    final format =
+        _transcodingService.enabled ? _transcodingService.format : null;
+    final url = _subsonicService.getStreamUrl(song.id,
+        maxBitRate: maxBitRate, format: format);
     // Cache remote streams locally so seeking works even when the server
     // transcodes and doesn't support HTTP range requests (issue #170).
     final cacheDir = await getTemporaryDirectory();

lib/services/transcoding_service.dart

@@ -4,7 +4,7 @@ import 'package:flutter/material.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 class TranscodeBitrate {
-  static const int original = 0; 
+  static const int original = 0;
   static const int kbps64 = 64;
   static const int kbps128 = 128;
   static const int kbps192 = 192;
@@ -27,7 +27,7 @@ class TranscodeBitrate {
 }
 
 class TranscodeFormat {
-  static const String original = 'raw'; 
+  static const String original = 'raw';
   static const String mp3 = 'mp3';
   static const String opus = 'opus';
   static const String aac = 'aac';
@@ -71,6 +71,11 @@ class TranscodingService extends ChangeNotifier {
 
   int get wifiBitrate => _wifiBitrate;
   int get mobileBitrate => _mobileBitrate;
+  int get currentBitRate => _smartEnabled
+      ? (_currentConnectionType == ConnectionType.wifi
+          ? _wifiBitrate
+          : _mobileBitrate)
+      : _wifiBitrate;
   String get format => _format;
   bool get enabled => _enabled;
   bool get smartEnabled => _smartEnabled;
@@ -99,18 +104,15 @@ class TranscodingService extends ChangeNotifier {
   }
 
   Future<void> _initConnectivityWatcher() async {
-    
     final result = await Connectivity().checkConnectivity();
     _updateConnectionType(result);
 
     _connectivitySub?.cancel();
-    _connectivitySub = Connectivity()
-        .onConnectivityChanged
-        .listen(_updateConnectionType);
+    _connectivitySub =
+        Connectivity().onConnectivityChanged.listen(_updateConnectionType);
   }
 
   void _updateConnectionType(List<ConnectivityResult> results) {
-    
     final newType = results.contains(ConnectivityResult.wifi)
         ? ConnectionType.wifi
         : ConnectionType.mobile;