Skip to content

Commit f2dd3b6

Browse files
committed
Added firefox web_ext_id to firefox manifest creation script
and removed it from it from the workflow see web-ext 5 release notes: https://github.com/mozilla/web-ext/releases/tag/5.0.0
1 parent 4263aa4 commit f2dd3b6

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ jobs:
114114
path: dist
115115
- name: Upload to firefox store
116116
env:
117-
WEB_EXT_ID: ${{ secrets.WEB_EXT_ID }}
118117
WEB_EXT_API_KEY: ${{ secrets.WEB_EXT_API_KEY }}
119118
WEB_EXT_API_SECRET: ${{ secrets.WEB_EXT_API_SECRET }}
120119
run: |

packages/ManifesFirefox.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,13 @@ export const createFirefoxManifest = () => {
44
const manifest = createChromeManifest();
55
delete manifest['offline_enabled'];
66
delete manifest['background']['persistent'];
7-
return manifest;
7+
const fireFoxSpecifficSettings = {
8+
browser_specific_settings: {
9+
gecko: {
10+
id: '{dd10a870-27c8-4b74-bfd4-0f767fe68770}',
11+
strict_min_version: '67.0'
12+
}
13+
}
14+
};
15+
return { ...manifest, ...fireFoxSpecifficSettings };
816
};

0 commit comments

Comments
 (0)