Skip to content

Commit 248ecc9

Browse files
xXSh4dowW4rriorXxCryptoCopter
authored andcommitted
fixed buffers in tests writing to expected value slice
1 parent a74bfb1 commit 248ecc9

3 files changed

Lines changed: 20 additions & 10 deletions

File tree

primitives_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ func TestUInt(t *testing.T) {
2828

2929
for _, test := range tests {
3030
// Read
31-
buff := bytes.NewBuffer(test.data)
31+
buff := &bytes.Buffer{}
32+
_, _ = buff.Write(test.data)
3233
if n, err := ReadUInt(buff); err != nil {
3334
t.Fatal(err)
3435
} else if n != test.numb {
@@ -218,7 +219,8 @@ func TestByteStringLen(t *testing.T) {
218219

219220
for _, test := range tests {
220221
// Read
221-
buff := bytes.NewBuffer(test.data)
222+
buff := &bytes.Buffer{}
223+
_, _ = buff.Write(test.data)
222224
if n, err := ReadByteStringLen(buff); err != nil {
223225
t.Fatal(err)
224226
} else if n != test.len {
@@ -252,7 +254,8 @@ func TestTextStringLen(t *testing.T) {
252254

253255
for _, test := range tests {
254256
// Read
255-
buff := bytes.NewBuffer(test.data)
257+
buff := &bytes.Buffer{}
258+
_, _ = buff.Write(test.data)
256259
if n, err := ReadTextStringLen(buff); err != nil {
257260
t.Fatal(err)
258261
} else if n != test.len {
@@ -285,7 +288,8 @@ func TestArrayLen(t *testing.T) {
285288

286289
for _, test := range tests {
287290
// Read
288-
buff := bytes.NewBuffer(test.data)
291+
buff := &bytes.Buffer{}
292+
_, _ = buff.Write(test.data)
289293
if n, err := ReadArrayLength(buff); err != nil {
290294
t.Fatal(err)
291295
} else if n != test.len {
@@ -318,7 +322,8 @@ func TestMapPairLen(t *testing.T) {
318322

319323
for _, test := range tests {
320324
// Read
321-
buff := bytes.NewBuffer(test.data)
325+
buff := &bytes.Buffer{}
326+
_, _ = buff.Write(test.data)
322327
if n, err := ReadMapPairLength(buff); err != nil {
323328
t.Fatal(err)
324329
} else if n != test.len {

simple_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ func TestBoolean(t *testing.T) {
1717

1818
for _, test := range tests {
1919
// Read
20-
buff := bytes.NewBuffer(test.data)
20+
buff := &bytes.Buffer{}
21+
_, _ = buff.Write(test.data)
2122
if b, err := ReadBoolean(buff); err != nil {
2223
t.Fatal(err)
2324
} else if b != test.b {
@@ -47,7 +48,8 @@ func TestFloat32(t *testing.T) {
4748

4849
for _, test := range tests {
4950
// Read
50-
buff := bytes.NewBuffer(test.data)
51+
buff := &bytes.Buffer{}
52+
_, _ = buff.Write(test.data)
5153
if f, err := ReadFloat32(buff); err != nil {
5254
t.Fatal(err)
5355
} else if f != test.f {
@@ -78,7 +80,8 @@ func TestFloat64(t *testing.T) {
7880

7981
for _, test := range tests {
8082
// Read
81-
buff := bytes.NewBuffer(test.data)
83+
buff := &bytes.Buffer{}
84+
_, _ = buff.Write(test.data)
8285
if f, err := ReadFloat64(buff); err != nil {
8386
t.Fatal(err)
8487
} else if f != test.f {

strings_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ func TestByteString(t *testing.T) {
2626

2727
for _, test := range tests {
2828
// Read
29-
buff := bytes.NewBuffer(test.cbor)
29+
buff := &bytes.Buffer{}
30+
_, _ = buff.Write(test.cbor)
3031
if data, err := ReadByteString(buff); err != nil {
3132
t.Fatal(err)
3233
} else if !reflect.DeepEqual(data, test.data) {
@@ -122,7 +123,8 @@ func TestReadTextString(t *testing.T) {
122123

123124
for _, test := range tests {
124125
// Read
125-
buff := bytes.NewBuffer(test.cbor)
126+
buff := &bytes.Buffer{}
127+
_, _ = buff.Write(test.cbor)
126128
if data, err := ReadTextString(buff); err != nil {
127129
t.Fatal(err)
128130
} else if data != test.data {

0 commit comments

Comments
 (0)