fix(plugins): resolve pr review feedback

duyet · duyet · commit a5a9771d7d2f · 2026-04-24T16:04:07.000+07:00
Move Codex metadata docs out of the install block and normalize Codex manifest display metadata.

Harden validation for Codex-only directories, missing marketplace files, and duplicate marketplace entries.
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -7,15 +7,17 @@
 /plugin install <plugin-name>@duyet-claude-plugins
 ```
 
+Alternative: `npx skills add duyet/claude-plugins` ([skills.sh](https://skills.sh))
+
+## Plugin Metadata
+
 Codex plugin metadata is maintained beside Claude metadata in each plugin:
 
 - Claude manifest: `.claude-plugin/plugin.json`
 - Codex manifest: `.codex-plugin/plugin.json`
 - Claude marketplace: `marketplace.json` and `.claude-plugin/marketplace.json`
 - Codex marketplace: `.agents/plugins/marketplace.json`
 
-Alternative: `npx skills add duyet/claude-plugins` ([skills.sh](https://skills.sh))
-
 ## Versioning
 
 Follow semantic versioning (semver) for all plugins:
diff --git a/clickhouse-monitoring/.codex-plugin/plugin.json b/clickhouse-monitoring/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Clickhouse Monitoring",
     "shortDescription": "Agent Skill for the ClickHouse Monitor dashboard - a real-time monitoring and observability tool for ClickHouse clusters. Covers 45 dashboard pages, query performance analysis, table management, and API integration.",
-    "longDescription": "Agent Skill for the ClickHouse Monitor dashboard - a real-time monitoring and observability tool for ClickHouse clusters. Covers 45 dashboard pages, query performance analysis, table management, and API integration.",
     "developerName": "duyet",
     "category": "Monitoring",
     "capabilities": [
diff --git a/clickhouse/.codex-plugin/plugin.json b/clickhouse/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Clickhouse",
     "shortDescription": "ClickHouse expertise with 28 atomic review rules + 14 deep reference files. Rules synced with official ClickHouse/agent-skills repository. Schema design, query optimization, insert strategy, cluster management, backups, monitoring, and security best practices.",
-    "longDescription": "ClickHouse expertise with 28 atomic review rules + 14 deep reference files. Rules synced with official ClickHouse/agent-skills repository. Schema design, query optimization, insert strategy, cluster management, backups, monitoring, and security best practices.",
     "developerName": "duyetbot",
     "category": "Database",
     "capabilities": [
diff --git a/commit/.codex-plugin/plugin.json b/commit/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Commit",
     "shortDescription": "Create a Git commit with semantic commit message format and PR workflow with templates",
-    "longDescription": "Create a Git commit with semantic commit message format and PR workflow with templates",
     "developerName": "duyet",
     "category": "Git",
     "capabilities": [
diff --git a/docs-generator/.codex-plugin/plugin.json b/docs-generator/.codex-plugin/plugin.json
@@ -10,7 +10,6 @@
   "interface": {
     "displayName": "Docs Generator",
     "shortDescription": "Automatically generate and maintain plugin documentation (README.md, CLAUDE.md)",
-    "longDescription": "Automatically generate and maintain plugin documentation (README.md, CLAUDE.md)",
     "developerName": "duyet",
     "category": "Docs",
     "capabilities": [
diff --git a/duyetbot/.codex-plugin/plugin.json b/duyetbot/.codex-plugin/plugin.json
@@ -11,7 +11,6 @@
   "interface": {
     "displayName": "Duyetbot",
     "shortDescription": "Pragmatic software development companion with engineering discipline and transparent execution.",
-    "longDescription": "Pragmatic software development companion with engineering discipline and transparent execution.",
     "developerName": "duyet",
     "category": "Productivity",
     "capabilities": [
diff --git a/fix/.codex-plugin/plugin.json b/fix/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Fix",
     "shortDescription": "Fix issues, tests, and CI failures with intelligent problem detection and resolution",
-    "longDescription": "Fix issues, tests, and CI failures with intelligent problem detection and resolution",
     "developerName": "duyet",
     "category": "Productivity",
     "capabilities": [
diff --git a/frontend-design/.codex-plugin/plugin.json b/frontend-design/.codex-plugin/plugin.json
@@ -10,7 +10,6 @@
   "interface": {
     "displayName": "Frontend Design",
     "shortDescription": "Create distinctive, production-grade frontend interfaces avoiding AI slop aesthetics. Emphasizes shadcn/ui, Recharts, and bold design choices.",
-    "longDescription": "Create distinctive, production-grade frontend interfaces avoiding AI slop aesthetics. Emphasizes shadcn/ui, Recharts, and bold design choices.",
     "developerName": "duyet",
     "category": "Design",
     "capabilities": [
diff --git a/github/.codex-plugin/plugin.json b/github/.codex-plugin/plugin.json
@@ -8,9 +8,8 @@
   "license": "MIT",
   "skills": "./skills/",
   "interface": {
-    "displayName": "Github",
+    "displayName": "GitHub",
     "shortDescription": "GitHub operations using gh CLI - PRs, workflows, issues, repositories, batch operations, PR babysitting with AI review bot integration, and smart branch detection",
-    "longDescription": "GitHub operations using gh CLI - PRs, workflows, issues, repositories, batch operations, PR babysitting with AI review bot integration, and smart branch detection",
     "developerName": "duyetbot",
     "category": "Git",
     "capabilities": [
diff --git a/interview/.codex-plugin/plugin.json b/interview/.codex-plugin/plugin.json
@@ -10,7 +10,6 @@
   "interface": {
     "displayName": "Interview",
     "shortDescription": "Conduct in-depth requirements interviews using Socratic questioning to clarify implementation details before coding",
-    "longDescription": "Conduct in-depth requirements interviews using Socratic questioning to clarify implementation details before coding",
     "developerName": "duyet",
     "category": "Productivity",
     "capabilities": [
diff --git a/orchestration/.codex-plugin/plugin.json b/orchestration/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Orchestration",
     "shortDescription": "Orchestrator skill for managing parallel agent workstreams. Transform complex requests into coordinated multi-agent execution with elegant result synthesis.",
-    "longDescription": "Orchestrator skill for managing parallel agent workstreams. Transform complex requests into coordinated multi-agent execution with elegant result synthesis.",
     "developerName": "duyet",
     "category": "Agents",
     "capabilities": [
diff --git a/prompt-engineering/.codex-plugin/plugin.json b/prompt-engineering/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Prompt Engineering",
     "shortDescription": "Prompt engineering skills for Grok, Claude, and Gemini LLMs with model-specific guidance and universal techniques",
-    "longDescription": "Prompt engineering skills for Grok, Claude, and Gemini LLMs with model-specific guidance and universal techniques",
     "developerName": "duyetbot",
     "category": "Productivity",
     "capabilities": [
diff --git a/scripts/validate-plugins.sh b/scripts/validate-plugins.sh
@@ -125,12 +125,18 @@ errors = []
 
 plugin_dirs = sorted(
     name for name in os.listdir(repo_root)
-    if os.path.isfile(os.path.join(repo_root, name, ".claude-plugin", "plugin.json"))
+    if (
+        os.path.isfile(os.path.join(repo_root, name, ".claude-plugin", "plugin.json"))
+        or os.path.isfile(os.path.join(repo_root, name, ".codex-plugin", "plugin.json"))
+    )
 )
 
 for plugin in plugin_dirs:
     claude_path = os.path.join(repo_root, plugin, ".claude-plugin", "plugin.json")
     codex_path = os.path.join(repo_root, plugin, ".codex-plugin", "plugin.json")
+    if not os.path.isfile(claude_path):
+        errors.append(f"{plugin}: missing .claude-plugin/plugin.json")
+        continue
     if not os.path.isfile(codex_path):
         errors.append(f"{plugin}: missing .codex-plugin/plugin.json")
         continue
@@ -172,10 +178,8 @@ def load_json(relpath):
     try:
         with open(os.path.join(repo_root, relpath)) as f:
             return json.load(f)
-    except FileNotFoundError:
-        errors.append(f"missing {relpath}")
-    except json.JSONDecodeError as exc:
-        errors.append(f"{relpath}: invalid JSON: {exc}")
+    except (FileNotFoundError, OSError, json.JSONDecodeError) as exc:
+        errors.append(f"{relpath}: {exc}")
     return None
 
 def require(condition, message):
@@ -186,6 +190,7 @@ root_marketplace = load_json("marketplace.json")
 if root_marketplace is None:
     root_marketplace = {"plugins": []}
 root_names = [plugin.get("name") for plugin in root_marketplace.get("plugins", [])]
+require(len(root_names) == len(set(root_names)), "marketplace.json contains duplicate plugin names")
 require(set(root_names) == plugin_set, "marketplace.json plugin names must match plugin directories")
 for plugin in root_marketplace.get("plugins", []):
     name = plugin.get("name")
@@ -210,6 +215,7 @@ codex_marketplace = load_json(".agents/plugins/marketplace.json")
 if codex_marketplace is None:
     codex_marketplace = {"plugins": []}
 codex_names = [plugin.get("name") for plugin in codex_marketplace.get("plugins", [])]
+require(len(codex_names) == len(set(codex_names)), ".agents/plugins/marketplace.json contains duplicate plugin names")
 require(set(codex_names) == plugin_set, ".agents/plugins/marketplace.json plugin names must match plugin directories")
 require(isinstance(codex_marketplace.get("interface", {}).get("displayName"), str), ".agents/plugins/marketplace.json missing interface.displayName")
 for plugin in codex_marketplace.get("plugins", []):
diff --git a/statusline/.codex-plugin/plugin.json b/statusline/.codex-plugin/plugin.json
@@ -10,7 +10,6 @@
   "interface": {
     "displayName": "Statusline",
     "shortDescription": "Multi-provider status bar with context health, API rate limits (Anthropic 5h/7d + z.ai GLM tokens/tools), git branch, and active tools. Auto-detects provider from model name. Supports 1/2/3 line layouts with smart hiding.",
-    "longDescription": "Multi-provider status bar with context health, API rate limits (Anthropic 5h/7d + z.ai GLM tokens/tools), git branch, and active tools. Auto-detects provider from model name. Supports 1/2/3 line layouts with smart hiding.",
     "developerName": "duyet",
     "category": "UI",
     "capabilities": [
diff --git a/team-agents/.codex-plugin/plugin.json b/team-agents/.codex-plugin/plugin.json
@@ -9,7 +9,6 @@
   "interface": {
     "displayName": "Team Agents",
     "shortDescription": "Leader and Senior Engineer agents for coordinated parallel task execution. Leader breaks down complex tasks and delegates to multiple senior engineers working in parallel.",
-    "longDescription": "Leader and Senior Engineer agents for coordinated parallel task execution. Leader breaks down complex tasks and delegates to multiple senior engineers working in parallel.",
     "developerName": "duyet",
     "category": "Agents",
     "capabilities": [
diff --git a/unsloth-training/.codex-plugin/plugin.json b/unsloth-training/.codex-plugin/plugin.json
@@ -10,7 +10,6 @@
   "interface": {
     "displayName": "Unsloth Training",
     "shortDescription": "Fine-tune LLMs with Unsloth using GRPO or SFT. Includes dataset preparation, synthetic data generation, environment flags, MLX (Apple Silicon), FP8, vision models, mobile export, GGUF.",
-    "longDescription": "Fine-tune LLMs with Unsloth using GRPO or SFT. Includes dataset preparation, synthetic data generation, environment flags, MLX (Apple Silicon), FP8, vision models, mobile export, GGUF.",
     "developerName": "duyet",
     "category": "ML",
     "capabilities": [
