fix(update): res.ok means it worked

kentcdodds · kentcdodds · commit 29ff902385b0 · 2025-06-24T23:52:28.000-06:00
diff --git a/packages/workshop-app/app/components/update-repo.tsx b/packages/workshop-app/app/components/update-repo.tsx
@@ -70,8 +70,10 @@ export function UpdateToast({
 									},
 								},
 							)
-							if (res.ok) {
-								throw new Error('Request to update workshop failed')
+							if (!res.ok) {
+								throw new Error(
+									`Request to update workshop failed: ${res.statusText}`,
+								)
 							}
 							const data = await res.json().catch(() => ({}))
 							const schema = z.object({

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,10 @@ export function UpdateToast({`
`70`	`70`	`},`
`71`	`71`	`},`
`72`	`72`	`)`
`73`		`- if (res.ok) {`
`74`		`- throw new Error('Request to update workshop failed')`
	`73`	`+ if (!res.ok) {`
	`74`	`+ throw new Error(`
	`75`	+ `Request to update workshop failed: ${res.statusText}`,
	`76`	`+ )`
`75`	`77`	`}`
`76`	`78`	`const data = await res.json().catch(() => ({}))`
`77`	`79`	`const schema = z.object({`