fix(mcp): Notification API (#486)

* Notification API refactor

* fix: update notification calls to match MCP logging schema

- Changed notification method signature from topic/payload to object with method/params
- Added required 'level' field to all notifications/message calls
- Set appropriate log levels: warning for timeout, error for failures, info for success
- Fixed TypeScript errors by using correct notification object structure

Co-authored-by: me <me@kentcdodds.com>

---------

Co-authored-by: seer-by-sentry[bot] <157164994+seer-by-sentry[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: me <me@kentcdodds.com>

Author: 3 people

packages/workshop-mcp/src/tools.ts

@@ -252,16 +252,17 @@ export function initTools(server: McpServer) {
 					name: z.string().nullable().optional(),
 				})
 
-				const timeout = setTimeout(() => {
-					void server.server
-						.notification({
-							method: 'notification',
-							params: {
-								message: 'Device authorization timed out',
-							},
-						})
-						.catch(() => {})
-				}, deviceResponse.expires_in * 1000)
+			const timeout = setTimeout(() => {
+				void server.server
+					.notification({
+						method: 'notifications/message',
+						params: {
+							level: 'warning',
+							data: 'Device authorization timed out',
+						},
+					})
+					.catch(() => {})
+			}, deviceResponse.expires_in * 1000)
 
 				try {
 					const tokenSet = await client.pollDeviceAuthorizationGrant(
@@ -270,15 +271,16 @@ export function initTools(server: McpServer) {
 					)
 					clearTimeout(timeout)
 
-					if (!tokenSet) {
-						await server.server.notification({
-							method: 'notification',
-							params: {
-								message: 'No token set',
-							},
-						})
-						return
-					}
+				if (!tokenSet) {
+					await server.server.notification({
+						method: 'notifications/message',
+						params: {
+							level: 'error',
+							data: 'No token set',
+						},
+					})
+					return
+				}
 
 					const protectedResourceResponse = await client.fetchProtectedResource(
 						config,
@@ -287,16 +289,17 @@ export function initTools(server: McpServer) {
 						'GET',
 					)
 					const userinfoRaw = await protectedResourceResponse.json()
-					const userinfoResult = UserInfoSchema.safeParse(userinfoRaw)
-					if (!userinfoResult.success) {
-						await server.server.notification({
-							method: 'notification',
-							params: {
-								message: `Failed to parse user info: ${userinfoResult.error.message}`,
-							},
-						})
-						return
-					}
+				const userinfoResult = UserInfoSchema.safeParse(userinfoRaw)
+				if (!userinfoResult.success) {
+					await server.server.notification({
+						method: 'notifications/message',
+						params: {
+							level: 'error',
+							data: `Failed to parse user info: ${userinfoResult.error.message}`,
+						},
+					})
+					return
+				}
 					const userinfo = userinfoResult.data
 
 					await setAuthInfo({
@@ -306,15 +309,16 @@ export function initTools(server: McpServer) {
 						name: userinfo.name,
 					})
 
-					await getUserInfo({ forceFresh: true })
+				await getUserInfo({ forceFresh: true })
 
-					await server.server.notification({
-						method: 'notification',
-						params: {
-							message: 'Authentication successful',
-						},
-					})
-				} catch (error) {
+				await server.server.notification({
+					method: 'notifications/message',
+					params: {
+						level: 'info',
+						data: 'Authentication successful',
+					},
+				})
+			} catch (error) {
 					clearTimeout(timeout)
 					throw error
 				}