fix: Missing playground app error (#552)

Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: kentcdodds

packages/workshop-utils/src/apps-server.test.ts

@@ -0,0 +1,64 @@
+import fs from 'node:fs/promises'
+import os from 'node:os'
+import path from 'node:path'
+import { afterEach, expect, test, vi } from 'vitest'
+
+const originalContext = process.env.EPICSHOP_CONTEXT_CWD
+
+async function createTempWorkshop() {
+	const root = await fs.mkdtemp(path.join(os.tmpdir(), 'epicshop-playground-'))
+	await fs.writeFile(
+		path.join(root, 'package.json'),
+		JSON.stringify(
+			{
+				name: 'epicshop-playground-test',
+				epicshop: {
+					title: 'Playground Test',
+					githubRepo: 'https://github.com/example/workshop',
+				},
+			},
+			null,
+			2,
+		),
+	)
+	await fs.mkdir(path.join(root, 'playground'), { recursive: true })
+	const cacheDir = path.join(root, 'node_modules', '.cache', 'epicshop')
+	await fs.mkdir(cacheDir, { recursive: true })
+	await fs.writeFile(
+		path.join(cacheDir, 'playground.json'),
+		JSON.stringify({ appName: '05.02.problem' }, null, 2),
+	)
+
+	return {
+		root,
+		async [Symbol.asyncDispose]() {
+			await fs.rm(root, { recursive: true, force: true })
+		},
+	}
+}
+
+afterEach(() => {
+	if (originalContext) {
+		process.env.EPICSHOP_CONTEXT_CWD = originalContext
+	} else {
+		delete process.env.EPICSHOP_CONTEXT_CWD
+	}
+})
+
+test('returns playground info when base app is missing', async () => {
+	await using workshop = await createTempWorkshop()
+
+	process.env.EPICSHOP_CONTEXT_CWD = workshop.root
+	;(
+		globalThis as { __epicshop_apps_initialized__?: boolean }
+	).__epicshop_apps_initialized__ = false
+	vi.resetModules()
+
+	const { getPlaygroundApp, setWorkshopRoot } = await import('./apps.server.ts')
+	setWorkshopRoot(workshop.root)
+
+	const playgroundApp = await getPlaygroundApp()
+	expect(playgroundApp).not.toBeNull()
+	expect(playgroundApp?.appName).toBe('05.02.problem')
+	expect(playgroundApp?.isUpToDate).toBe(false)
+}, 15000)

packages/workshop-utils/src/apps.server.ts

@@ -806,6 +806,13 @@ export async function getFullPathFromAppName(appName: string) {
 	return dir ?? appName
 }
 
+async function resolveExistingAppPath(appName: string) {
+	const fullPath = await getFullPathFromAppName(appName)
+	if (!path.isAbsolute(fullPath)) return null
+	if (!(await exists(fullPath))) return null
+	return fullPath
+}
+
 export async function findSolutionDir({
 	fullPath,
 }: {
@@ -827,10 +834,11 @@ export async function findSolutionDir({
 		}
 	} else if (fullPath.endsWith('playground')) {
 		const appName = await getPlaygroundAppName()
-		if (appName) {
-			return findSolutionDir({
-				fullPath: await getFullPathFromAppName(appName),
-			})
+		const baseAppFullPath = appName
+			? await resolveExistingAppPath(appName)
+			: null
+		if (baseAppFullPath) {
+			return findSolutionDir({ fullPath: baseAppFullPath })
 		}
 	}
 	return null
@@ -857,8 +865,11 @@ export async function findProblemDir({
 		}
 	} else if (fullPath.endsWith('playground')) {
 		const appName = await getPlaygroundAppName()
-		if (appName) {
-			return findProblemDir({ fullPath: await getFullPathFromAppName(appName) })
+		const baseAppFullPath = appName
+			? await resolveExistingAppPath(appName)
+			: null
+		if (baseAppFullPath) {
+			return findProblemDir({ fullPath: baseAppFullPath })
 		}
 	}
 	return null
@@ -944,11 +955,14 @@ export async function getPlaygroundApp({
 }: CachifiedOptions = {}): Promise<PlaygroundApp | null> {
 	const playgroundDir = path.join(getWorkshopRoot(), 'playground')
 	const baseAppName = await getPlaygroundAppName()
-	const key = `playground-${baseAppName}`
-
 	const baseAppFullPath = baseAppName
-		? await getFullPathFromAppName(baseAppName)
+		? await resolveExistingAppPath(baseAppName)
 		: null
+	if (baseAppName && !baseAppFullPath) {
+		log.warn(`Playground base app missing: ${baseAppName}`)
+	}
+	const key = `playground-${baseAppName}`
+
 	const playgroundCacheEntry = await playgroundAppCache.get(key)
 	return cachified({
 		key,
@@ -978,18 +992,20 @@ export async function getPlaygroundApp({
 				getDevInfo({ fullPath: playgroundDir, portNumber }),
 			])
 
-			const appModifiedTime = await getDirModifiedTime(
-				await getFullPathFromAppName(baseAppName),
-			)
 			const playgroundAppModifiedTime = await getDirModifiedTime(playgroundDir)
+			const appModifiedTime = baseAppFullPath
+				? await getDirModifiedTime(baseAppFullPath)
+				: -1
 			const type = 'playground'
 
 			const title = compiledReadme?.title ?? name
 			return {
 				name,
 				appName: baseAppName,
 				type,
-				isUpToDate: appModifiedTime <= playgroundAppModifiedTime,
+				isUpToDate: baseAppFullPath
+					? appModifiedTime <= playgroundAppModifiedTime
+					: false,
 				fullPath: playgroundDir,
 				relativePath: playgroundDir.replace(
 					`${getWorkshopRoot()}${path.sep}`,