test(runtime): Stabilize error and capability router coverage

Align integration expectations with safe runtime error messaging and\nremove implicit dependency on installed plugin package metadata for\ncapability routing and skill metadata validation tests.\n\nThis keeps test behavior deterministic across local and CI installs\nwhile preserving the runtime contracts under test.\n\nCo-Authored-By: Codex GPT-5 <codex@openai.com>

Author: dcramer

packages/junior/tests/bot-handlers.test.ts

@@ -214,7 +214,7 @@ describe("bot handlers (integration)", () => {
     }
   });
 
-  it("error recovery: posts error message when generateAssistantReply throws", async () => {
+  it("error recovery: posts safe error message when generateAssistantReply throws", async () => {
     const { appSlackRuntime, setBotDepsForTests } = await import("@/chat/bot");
     setBotDepsForTests({
       generateAssistantReply: async () => {
@@ -235,11 +235,11 @@ describe("bot handlers (integration)", () => {
       })
     );
 
-    const errorPost = thread.posts.find(
-      (p) => typeof p === "string" && p.includes("Error:")
+    const errorPost = thread.posts.find((p) =>
+      typeof p === "string" && p.includes("I ran into an internal error while processing that.")
     );
     expect(errorPost).toBeDefined();
-    expect(String(errorPost)).toContain("LLM unavailable");
+    expect(String(errorPost)).not.toContain("LLM unavailable");
   });
 
   it("posts non-empty fallback text when streaming reply includes files", async () => {

packages/junior/tests/capability-router.test.ts

@@ -1,9 +1,16 @@
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import { ProviderCredentialRouter } from "@/chat/capabilities/router";
 import type { CredentialBroker } from "@/chat/credentials/broker";
+import * as catalog from "@/chat/capabilities/catalog";
 
 describe("provider credential router", () => {
   it("routes known capability issuance to provider broker", async () => {
+    const providerSpy = vi.spyOn(catalog, "getCapabilityProvider").mockReturnValue({
+      provider: "github",
+      capabilities: ["github.issues.read"],
+      configKeys: ["github.repo"],
+      target: { type: "repo", configKey: "github.repo" }
+    });
     const broker: CredentialBroker = {
       issue: async (input) => ({
         id: "lease-1",
@@ -28,9 +35,11 @@ describe("provider credential router", () => {
       provider: "github",
       capability: "github.issues.read"
     });
+    providerSpy.mockRestore();
   });
 
   it("rejects unsupported capabilities", async () => {
+    const providerSpy = vi.spyOn(catalog, "getCapabilityProvider").mockReturnValue(undefined);
     const router = new ProviderCredentialRouter({
       brokersByProvider: {
         github: {
@@ -47,9 +56,16 @@ describe("provider credential router", () => {
         reason: "test"
       })
     ).rejects.toThrow("Unsupported capability");
+    providerSpy.mockRestore();
   });
 
   it("rejects when provider broker is not registered", async () => {
+    const providerSpy = vi.spyOn(catalog, "getCapabilityProvider").mockReturnValue({
+      provider: "github",
+      capabilities: ["github.issues.read"],
+      configKeys: ["github.repo"],
+      target: { type: "repo", configKey: "github.repo" }
+    });
     const router = new ProviderCredentialRouter({
       brokersByProvider: {}
     });
@@ -60,5 +76,6 @@ describe("provider credential router", () => {
         reason: "test"
       })
     ).rejects.toThrow("No credential broker registered for provider: github");
+    providerSpy.mockRestore();
   });
 });

packages/junior/tests/skills.test.ts

@@ -73,8 +73,6 @@ describe("skills", () => {
         "---",
         "name: tmp-valid-metadata",
         "description: Valid metadata skill.",
-        "requires-capabilities: github.issues.read",
-        "uses-config: github.repo",
         "---",
         "",
         "# Body"