Commit f114afa
fix(chat): require proper sentence structure for reportProgress messages (#245)
## Summary
The `reportProgress` tool description listed capitalized examples
("Searching docs", "Reviewing results", "Running checks") but did not
state the rule, so the model sometimes emitted lowercase status text
like `researching foo bar` instead of `Researching foo bar`.
This PR makes the expectation explicit in both the tool surface the
model sees and the delivery spec:
- Updated the `reportProgress` tool `description` and `message`
parameter description in
`packages/junior/src/chat/tools/runtime/report-progress.ts` to require
messages be written as a proper sentence fragment (capitalized first
letter, present-participle verb), with a positive/negative example.
- Updated `specs/slack-agent-delivery-spec.md` progress policy to match,
with a changelog entry.
No behavior/runtime code changed — this is guidance surfaced to the
model through the tool schema.
## Review & Testing Checklist for Human
- [ ] Confirm the wording in the tool description reads naturally to the
model and isn't overly prescriptive to the point of producing
stiff/robotic phrases.
- [ ] Confirm the spec wording in `specs/slack-agent-delivery-spec.md`
line 138 is consistent with how other progress-policy bullets are
worded.
### Notes
- No new tests: the existing `agent-tools.test.ts` covers the runtime
behavior (trimming + status emission) and still passes; this change is
purely to the model-facing description string.
Link to Devin session:
https://app.devin.ai/sessions/1b0dd6c839fe42048aa46eb31bc54471
Requested by: @dcramer
---------
Co-authored-by: David Cramer <david@sentry.io>
Co-authored-by: Devin <devin-ai-integration[bot]@users.noreply.github.com>1 parent 957c740 commit f114afa
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
138 | | - | |
| 139 | + | |
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| |||
0 commit comments