[terminal-stylist] Terminal Stylist: Console Output Analysis for gh-aw

[github-actions[bot]]

Overview

This report summarizes the results of a Terminal Stylist analysis of all non-test Go source files in pkg/ — covering console output patterns, Lipgloss styling, and Huh form implementations.

Key Metrics

Metric	Count
Total Go source files (non-test)	917
Files using fmt.Print*	257
Files using console.Format* / Render*	194
Files using huh forms	13
Files using Lipgloss directly	8
console.Format* calls in pkg/cli/	1,559
Huh NewForm / NewGroup calls in pkg/cli/	37
Huh forms with .WithTheme(styles.HuhTheme)	17
Raw blank-line spacers (fmt.Fprintln(os.Stderr, ""))	152

---

Lipgloss Usage — ✅ Excellent

The Lipgloss integration is well-architected:

• pkg/styles/theme.go defines a centralized adaptive color palette (Dracula-inspired dark / readable light) using compat.AdaptiveColor{Light: ..., Dark: ...} for every semantic color — ColorError, ColorWarning, ColorSuccess, ColorInfo, ColorPurple, ColorYellow, ColorComment, ColorForeground, ColorBackground, ColorBorder, ColorTableAltRow.
• TTY detection is handled correctly via pkg/tty (IsStdoutTerminal, IsStderrTerminal) and the applyStyle() helper in pkg/console/console.go gates all styling.
• Adaptive color init (styles.init()) correctly handles Windows startup probing — skips terminal capability queries on non-character-device handles to prevent hangs.
• Tables (console.RenderTable) use lipgloss/table with alternating row colors, rounded borders, proper header / total row styles.
• No manual ANSI escape codes found anywhere in the codebase — all color output goes through Lipgloss.
• No hardcoded hex colors outside pkg/styles/theme.go — the palette is single-sourced.

Lipgloss direct usage (8 files outside console/styles)

File	Usage
pkg/logger/logger.go	Color palette array for debug-logger channel labels (correct pattern)
pkg/cli/compile_schedule_calendar.go	intensityStyle() helper returns lipgloss.Style for heatmap (TTY-gated)

Both usages correctly reference styles.Color* constants — no ad-hoc hex values.

---

Huh Form Usage — ✅ Consistent, Minor Gap

The charm.land/huh integration is solid across 13 files:

• All interactive forms apply .WithTheme(styles.HuhTheme).WithAccessible(console.IsAccessibleMode()) — 100% of pkg/cli/ forms follow this pattern.
• pkg/console/confirm.go, pkg/console/list.go, and pkg/console/input.go provide TTY-guarded wrappers that fall back to plain-text prompts in non-TTY environments.
• styles.HuhTheme (pkg/styles/huh_theme.go) maps the full Dracula palette to every huh component: focused/blurred bases, navigation indicators, selection states, button styles, text cursor, and group headers — ensuring visual consistency between forms and the rest of the CLI.

Minor gap: Direct huh.NewForm calls in pkg/cli/ (not going through the console/ wrappers) do not guard with an explicit TTY check before running. The console/confirm.go and console/list.go wrappers do check tty.IsStderrTerminal() first, but add_interactive_auth.go, add_interactive_engine.go, engine_secrets.go, etc. call .RunWithContext() without a prior TTY guard. Huh handles non-TTY output gracefully, but explicit TTY detection keeps behavior consistent.

Files with direct huh forms (all consistently themed)

File	Forms	TTY Guard
pkg/cli/add_interactive_auth.go	1	❌
pkg/cli/add_interactive_engine.go	2	❌
pkg/cli/add_interactive_git.go	2	❌
pkg/cli/add_interactive_orchestrator.go	1	❌
pkg/cli/add_interactive_schedule.go	1	❌
pkg/cli/add_interactive_workflow.go	1	❌
pkg/cli/engine_secrets.go	3	❌
pkg/cli/interactive.go	3	❌
pkg/cli/run_interactive.go	3	✅ (line 175)

---

Console Output Patterns — ✅ Well-Structured, Areas to Improve

The pkg/console/ package provides a rich set of format helpers that are heavily used:

Function	Usage count (pkg/cli/)
console.FormatInfoMessage	645
console.FormatWarningMessage	469
console.FormatSuccessMessage	214
console.FormatVerboseMessage	69
console.FormatErrorMessage	61
console.FormatCommandMessage	20
console.FormatSectionHeader	19
console.RenderTable	29
console.RenderStruct	14

This is excellent coverage — user-facing status messages are consistently routed through the console formatting layer.

Anti-patterns found

1. Manual separator strings (2 files)

Two files hard-code box-drawing characters instead of using console.FormatSectionHeader() or console.RenderTitleBox():

pkg/cli/actionlint.go (lines 118–168):

// ❌ Current
separator := strings.Repeat("━", 60)
fmt.Fprintf(os.Stderr, "\n%s\n", separator)
fmt.Fprintf(os.Stderr, "%s\n\n", separator)

// ✅ Recommended
fmt.Fprintln(os.Stderr, console.FormatSectionHeader("Actionlint Summary"))

pkg/cli/add_interactive_orchestrator.go (lines 320–323):

// ❌ Current
fmt.Fprintln(os.Stderr, "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━")
fmt.Fprintln(os.Stderr, console.FormatSuccessMessage("🎉 Addition complete!"))
fmt.Fprintln(os.Stderr, "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━")

// ✅ Recommended — use RenderTitleBox for emphasis
for _, line := range console.RenderTitleBox("🎉 Addition complete!", 40) {
    fmt.Fprintln(os.Stderr, line)
}

2. Plain instructional text without styling (interactive wizard files)

Several messages in the add_interactive_* wizard files output plain text that could benefit from console formatting:

pkg/cli/add_interactive_auth.go:

// ❌ Current
fmt.Fprintln(os.Stderr, "Please navigate to a git repository or initialize one with:")

// ✅ Recommended
fmt.Fprintln(os.Stderr, console.FormatInfoMessage("Please navigate to a git repository or initialize one with:"))

pkg/cli/add_interactive_git.go:

// ❌ Current
fmt.Fprintln(os.Stderr, "Please merge the PR manually: "+result.PRURL)
fmt.Fprintln(os.Stderr, "Please add the secret manually:")

// ✅ Recommended
fmt.Fprintln(os.Stderr, console.FormatWarningMessage("Please merge the PR manually: "+result.PRURL))
fmt.Fprintln(os.Stderr, console.FormatInfoMessage("Please add the secret manually:"))

pkg/cli/add_interactive_orchestrator.go:

// ❌ Current
fmt.Fprintln(os.Stderr, "Useful commands:")
fmt.Fprintln(os.Stderr, "Learn more at: https://github.github.com/gh-aw/")
fmt.Fprintln(os.Stderr, "Operation cancelled.")

// ✅ Recommended
fmt.Fprintln(os.Stderr, console.FormatSectionHeader("Useful commands"))
fmt.Fprintln(os.Stderr, console.FormatInfoMessage("Learn more at: https://github.github.com/gh-aw/"))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage("Operation cancelled."))

3. Markdown report renderers (intentional — NOT an issue)

pkg/cli/audit_cross_run_render.go and pkg/cli/audit_diff_render.go emit raw Markdown via fmt.Fprintf(os.Stdout, ...). This is intentional — these functions (renderCrossRunReportMarkdown, renderMarkdown*) produce structured Markdown output for GitHub issue/PR bodies or file storage, not styled terminal output. This pattern is correct and should not be changed to Lipgloss rendering.

4. FormatErrorMessage double-prefix in add_workflow_compilation.go

Some callers pass a message already containing ✗ into FormatErrorMessage, which adds its own ✗ prefix — resulting in ✗ ✗ message. Example:

// ❌ Potential double-prefix
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("✗ %s/action.yml: %s", actionName, err.Error())))

// ✅ Recommended
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("%s/action.yml: %s", actionName, err.Error())))

---

Recommendations

Priority	Recommendation	Files
🔴 High	Replace manual strings.Repeat("━", N) separators with console.FormatSectionHeader() or console.RenderTitleBox()	actionlint.go, add_interactive_orchestrator.go
🟡 Medium	Wrap plain instructional text in console.FormatInfoMessage() / console.FormatWarningMessage() in wizard files	add_interactive_auth.go, add_interactive_git.go, add_interactive_orchestrator.go, add_interactive_engine.go, add_interactive_workflow.go
🟡 Medium	Add explicit tty.IsStderrTerminal() guard before huh form .RunWithContext() in CLI files not going through console/ wrappers	8 files (see table above)
🟢 Low	Remove redundant emoji prefixes (✗, ✓) in messages passed to console.Format* functions that already add their own prefix glyphs	actions_build_command.go
🟢 Low	Consider extracting the completion banner pattern (separator + success + separator + commands) from add_interactive_orchestrator.go into a reusable console.RenderCompletionBanner() helper	add_interactive_orchestrator.go

---

References: §27540682682

Generated by 💄 Terminal Stylist · 516.3 AIC · ⌖ 26.7 AIC · ⊞ 21K · ◷

• expires on Jun 16, 2026, 2:50 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-16T10:50:03.875Z.

Closed by Workflow