Commit 4c831ff
authored
Revise SVS_CHECK_BOUNDS logic (#301)
- Refactors `SVS_CHECK_BOUNDS` logic so that explicitly passing
`SVS_EXPERIMENTAL_CHECK_BOUNDS` will trump any other settings, but not
explicitly passing will lead to `SVS_CHECK_BOUNDS` depending on
`CMAKE_BUILD_TYPE`
- Previously, non-Release builds would force bounds checking on even
when a user explicitly passed -`DSVS_EXPERIMENTAL_CHECK_BOUNDS=OFF`, but
this now changes - see table below for more details
- Updates docs to reflect the conditional default
SVS_CHECK_BOUNDS value (current behavior)
<img width="599" height="72" alt="image"
src="https://github.com/user-attachments/assets/1ec5cce8-4dee-47c0-95d5-35619a91a1b3"
/>
SVS_CHECK_BOUNDS value (updated behavior)
<img width="599" height="73" alt="image"
src="https://github.com/user-attachments/assets/f05e0bf6-c083-49b8-acdc-4eea9e272cc1"
/>1 parent 1a33e4e commit 4c831ff
1 file changed
Lines changed: 13 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
89 | 97 | | |
90 | 98 | | |
91 | 99 | | |
| |||
126 | 134 | | |
127 | 135 | | |
128 | 136 | | |
129 | | - | |
130 | | - | |
| 137 | + | |
131 | 138 | | |
132 | 139 | | |
133 | 140 | | |
| |||
0 commit comments