Implement polling-based BMC metrics collection

Closes #813

Author: stefanhipfel

api/v1alpha1/bmc_types.go

@@ -206,14 +206,6 @@ type BMCStatus struct {
 	// +optional
 	LastResetTime *metav1.Time `json:"lastResetTime,omitempty"`
 
-	// MetricsReportSubscriptionLink is the link to the metrics report subscription of the bmc.
-	// +optional
-	MetricsReportSubscriptionLink string `json:"metricsReportSubscriptionLink,omitempty"`
-
-	// EventsSubscriptionLink is the link to the events subscription of the bmc.
-	// +optional
-	EventsSubscriptionLink string `json:"eventsSubscriptionLink,omitempty"`
-
 	// Conditions represents the latest available observations of the BMC's current state.
 	// +patchStrategy=merge
 	// +patchMergeKey=type

bmc/bmc.go

@@ -138,6 +138,12 @@ type BMC interface {
 	// CheckBMCPendingComponentUpgrade checks if there are pending/staged firmware upgrades
 	// for the given component type.
 	CheckBMCPendingComponentUpgrade(ctx context.Context, componentType ComponentType) (bool, error)
+
+	// GetMetricReport retrieves the current metric report from the BMC.
+	GetMetricReport(ctx context.Context) (MetricsReport, error)
+
+	// GetEventLog retrieves recent events from the BMC's System Event Log.
+	GetEventLog(ctx context.Context) ([]Event, error)
 }
 
 type Entity struct {
@@ -297,3 +303,32 @@ type Manager struct {
 	MACAddress      string
 	OemLinks        json.RawMessage
 }
+
+// MetricsReport represents a Redfish telemetry metric report.
+type MetricsReport struct {
+	ODataID      string        `json:"@odata.id,omitempty"`
+	ODataType    string        `json:"@odata.type,omitempty"`
+	ID           string        `json:"Id,omitempty"`
+	Name         string        `json:"Name,omitempty"`
+	MetricValues []MetricValue `json:"MetricValues,omitempty"`
+}
+
+// MetricValue represents a single metric value in a metric report.
+type MetricValue struct {
+	MetricID        string `json:"MetricId"`
+	MetricProperty  string `json:"MetricProperty"`
+	MetricValue     string `json:"MetricValue"`
+	Units           string `json:"Units"`
+	MetricValueKind string `json:"MetricValueKind"`
+	Timestamp       string `json:"Timestamp"`
+	Oem             any    `json:"Oem"`
+}
+
+// Event represents a Redfish event or alert.
+type Event struct {
+	EventID           string `json:"EventId"`
+	Message           string `json:"Message"`
+	Severity          string `json:"Severity"`
+	EventTimestamp    string `json:"EventTimestamp"`
+	OriginOfCondition string `json:"OriginOfCondition"`
+}

bmc/mock/server/data/index.json

@@ -60,4 +60,4 @@
     },
     "@odata.id": "/redfish/v1/",
     "@Redfish.Copyright": "Copyright 2014-2023 DMTF. For the full DMTF copyright policy, see http://www.dmtf.org/about/policies/copyright."
-}
+}

bmc/redfish.go

@@ -1140,3 +1140,106 @@ func (r *RedfishBaseBMC) DeleteEventSubscription(ctx context.Context, uri string
 	}
 	return nil
 }
+
+// GetMetricReport retrieves the current metric report from the BMC via TelemetryService.
+// If TelemetryService is not available, returns an empty report (fallback to events).
+func (r *RedfishBaseBMC) GetMetricReport(ctx context.Context) (MetricsReport, error) {
+	service := r.client.GetService()
+
+	// Try TelemetryService first (Redfish 2018.3+)
+	telemetry, err := service.TelemetryService()
+	if err == nil && telemetry != nil {
+		// Get metric reports
+		reports, err := telemetry.MetricReports()
+		if err == nil && len(reports) > 0 {
+			// Use the first available report and convert to our format
+			report := reports[0]
+			metricValues := make([]MetricValue, 0)
+
+			// Try to extract metric values - schema may vary by vendor
+			// The report.MetricValues is a slice of report-specific values
+			// We'll create a simple representation
+			for i := 0; i < len(report.MetricValues); i++ {
+				metricValues = append(metricValues, MetricValue{
+					MetricID:        fmt.Sprintf("Metric%d", i),
+					MetricProperty:  report.ODataID,
+					MetricValue:     fmt.Sprintf("%v", report.MetricValues[i]),
+					MetricValueKind: "Gauge",
+					Timestamp:       time.Now().Format(time.RFC3339),
+				})
+			}
+
+			return MetricsReport{
+				ODataID:      report.ODataID,
+				ODataType:    report.ODataType,
+				ID:           report.ID,
+				Name:         report.Name,
+				MetricValues: metricValues,
+			}, nil
+		}
+	}
+
+	// Fallback: Return empty report - polling will rely on event subscriptions or vendor-specific implementations
+	return MetricsReport{
+		ID:           "EmptyMetrics",
+		Name:         "No TelemetryService available",
+		MetricValues: []MetricValue{},
+	}, nil
+}
+
+// GetEventLog retrieves recent events from the BMC's System Event Log (SEL).
+// Returns events from the last 10 minutes by default.
+func (r *RedfishBaseBMC) GetEventLog(ctx context.Context) ([]Event, error) {
+	service := r.client.GetService()
+	systems, err := service.Systems()
+	if err != nil {
+		return nil, fmt.Errorf("failed to get systems: %w", err)
+	}
+	if len(systems) == 0 {
+		return nil, fmt.Errorf("no systems found")
+	}
+
+	system := systems[0]
+
+	// Get log services
+	logServices, err := system.LogServices()
+	if err != nil {
+		return nil, fmt.Errorf("failed to get log services: %w", err)
+	}
+
+	events := []Event{}
+
+	// Query each log service
+	for _, logService := range logServices {
+		entries, err := logService.Entries()
+		if err != nil {
+			continue // Skip log services that fail
+		}
+
+		// Filter to recent entries (last 10 minutes)
+		cutoff := time.Now().Add(-10 * time.Minute)
+
+		for _, entry := range entries {
+			// Parse timestamp
+			var entryTime time.Time
+			if entry.Created != "" {
+				entryTime, _ = time.Parse(time.RFC3339, entry.Created)
+			}
+
+			// Skip old entries
+			if !entryTime.IsZero() && entryTime.Before(cutoff) {
+				continue
+			}
+
+			events = append(events, Event{
+				EventID:           entry.ID,
+				Message:           entry.Message,
+				Severity:          string(entry.Severity),
+				EventTimestamp:    entry.Created,
+				OriginOfCondition: entry.ODataID,
+			})
+		}
+	}
+
+	return events, nil
+}