Problem
SonarQube reports a code smell in AdminController.java:
"Define a constant instead of duplicating this literal
redirect:/admin/products (3 times)
redirect:/admin/categories (3 times)
categories (4 times)
Duplicated string literals make code harder to maintain —
if the URL changes, it must be updated in multiple places.
Solution
Define a private static final constant in AdminController:
private static final String REDIRECT_ADMIN_PRODUCTS = "redirect:/admin/products";
private static final String REDIRECT_ADMIN_CATEGORIES = "redirect:/admin/categories";
private static final String VIEW_CATEGORIES = "categories";
Then replace all occurrences with these constant.
Type
Problem
SonarQube reports a code smell in AdminController.java:
"Define a constant instead of duplicating this literal
redirect:/admin/products (3 times)
redirect:/admin/categories (3 times)
categories (4 times)
Duplicated string literals make code harder to maintain —
if the URL changes, it must be updated in multiple places.
Solution
Define a private static final constant in AdminController:
private static final String REDIRECT_ADMIN_PRODUCTS = "redirect:/admin/products";
private static final String REDIRECT_ADMIN_CATEGORIES = "redirect:/admin/categories";
private static final String VIEW_CATEGORIES = "categories";
Then replace all occurrences with these constant.
Type