ACLP Logs destination - fix unit tests

Signed-off-by: sjerecze <sjerecze@akamai.com>

Author: sjer-akamai

linode/monitorlogsdestination/framework_models.go

@@ -225,18 +225,29 @@ func (m *LogsDestinationDataSourceModel) ParseLogsDestination(dest *linodego.Log
 	flat := &LogsDestinationFlatDetailsModel{}
 	d := dest.Details
 
-	flat.AccessKeyID = types.StringValue(d.AccessKeyID)
-	flat.BucketName = types.StringValue(d.BucketName)
-	flat.Host = types.StringValue(d.Host)
-	flat.Path = types.StringValue(d.Path)
-	flat.EndpointURL = types.StringValue(d.EndpointURL)
-	flat.ContentType = types.StringValue(d.ContentType)
-	flat.DataCompression = types.StringValue(d.DataCompression)
-
-	if d.Authentication != nil {
+	stringOrNull := func(s string) types.String {
+		if s == "" {
+			return types.StringNull()
+		}
+		return types.StringValue(s)
+	}
+
+	flat.AccessKeyID = stringOrNull(d.AccessKeyID)
+	flat.BucketName = stringOrNull(d.BucketName)
+	flat.Host = stringOrNull(d.Host)
+	flat.Path = stringOrNull(d.Path)
+	flat.EndpointURL = stringOrNull(d.EndpointURL)
+	flat.ContentType = stringOrNull(d.ContentType)
+	flat.DataCompression = stringOrNull(d.DataCompression)
+
+	// Handle nested structs gracefully
+	flat.AuthenticationType = types.StringNull()
+	if d.Authentication != nil && d.Authentication.Type != "" {
 		flat.AuthenticationType = types.StringValue(string(d.Authentication.Type))
 	}
-	if d.ClientCertificateDetails != nil {
+
+	flat.TLSHostname = types.StringNull()
+	if d.ClientCertificateDetails != nil && d.ClientCertificateDetails.TLSHostname != "" {
 		flat.TLSHostname = types.StringValue(d.ClientCertificateDetails.TLSHostname)
 	}
 

linode/monitorlogsdestination/framework_models_unit_test.go

@@ -183,10 +183,10 @@ func TestParseLogsDestination_DataSource(t *testing.T) {
 	assert.Equal(t, types.Int64Value(2), m.Version)
 
 	assert.NotNil(t, m.Details)
-	assert.Equal(t, "DSKEY", m.Details.AccessKeyID)
-	assert.Equal(t, "ds-bucket", m.Details.BucketName)
-	assert.Equal(t, "eu-central-1.linodeobjects.com", m.Details.Host)
-	assert.Equal(t, "/ds-logs", m.Details.Path)
+	assert.Equal(t, types.StringValue("DSKEY"), m.Details.AccessKeyID)
+	assert.Equal(t, types.StringValue("ds-bucket"), m.Details.BucketName)
+	assert.Equal(t, types.StringValue("eu-central-1.linodeobjects.com"), m.Details.Host)
+	assert.Equal(t, types.StringValue("/ds-logs"), m.Details.Path)
 }
 
 func TestParseLogsDestination_DataSource_CustomHTTPS(t *testing.T) {
@@ -228,14 +228,14 @@ func TestParseLogsDestination_DataSource_CustomHTTPS(t *testing.T) {
 	assert.Equal(t, types.Int64Value(3), m.Version)
 
 	assert.NotNil(t, m.Details)
-	assert.Equal(t, "https://logs.example.com/ingest", m.Details.EndpointURL)
-	assert.Equal(t, "application/json", m.Details.ContentType)
-	assert.Equal(t, "gzip", m.Details.DataCompression)
-	assert.Equal(t, "basic", m.Details.AuthenticationType)
-	assert.Equal(t, "logs.example.com", m.Details.TLSHostname)
+	assert.Equal(t, types.StringValue("https://logs.example.com/ingest"), m.Details.EndpointURL)
+	assert.Equal(t, types.StringValue("application/json"), m.Details.ContentType)
+	assert.Equal(t, types.StringValue("gzip"), m.Details.DataCompression)
+	assert.Equal(t, types.StringValue("basic"), m.Details.AuthenticationType)
+	assert.Equal(t, types.StringValue("logs.example.com"), m.Details.TLSHostname)
 
 	// OBJ storage fields must be empty for a custom_https destination.
-	assert.Empty(t, m.Details.AccessKeyID)
-	assert.Empty(t, m.Details.BucketName)
-	assert.Empty(t, m.Details.Host)
+	assert.True(t, m.Details.AccessKeyID.IsNull())
+	assert.True(t, m.Details.BucketName.IsNull())
+	assert.True(t, m.Details.Host.IsNull())
 }