Bug Description
[This is not strictly a bug but IMHO confusing and potentially risky]
When using OpenAI LLM with Azure, there is a default value for the model parameter. The LLM doesn't seem to use this parameter at all (instead uses azure_deployment), but given the relation to "real" OpenAI LLM this may change in the future. Then this default might become active unnoticed.
Also, the model property of the LLM object will return the default if it is not overridden. There is no property for azure_deployment.
I would suggest to remove the default and allow None as value. Maybe the model property can be an alias for azure_deployment.
This is the respective line in the code where the default is set:
|
model: str | ChatModels = "gpt-4o", |
Expected Behavior
Azure LLM has None default for model property or mirrors azure_deployment.
Reproduction Steps
1.
2.
3.
...
- Sample code snippet, or a GitHub Gist link -
Operating System
any
Models Used
OpenAI
Package Versions
Session/Room/Call IDs
No response
Proposed Solution
Additional Context
No response
Screenshots and Recordings
No response
Bug Description
[This is not strictly a bug but IMHO confusing and potentially risky]
When using OpenAI LLM with Azure, there is a default value for the
modelparameter. The LLM doesn't seem to use this parameter at all (instead usesazure_deployment), but given the relation to "real" OpenAI LLM this may change in the future. Then this default might become active unnoticed.Also, the
modelproperty of the LLM object will return the default if it is not overridden. There is no property for azure_deployment.I would suggest to remove the default and allow None as value. Maybe the
modelproperty can be an alias for azure_deployment.This is the respective line in the code where the default is set:
agents/livekit-plugins/livekit-plugins-openai/livekit/plugins/openai/llm.py
Line 193 in 0fdada7
Expected Behavior
Azure LLM has
Nonedefault for model property or mirrors azure_deployment.Reproduction Steps
Operating System
any
Models Used
OpenAI
Package Versions
Session/Room/Call IDs
No response
Proposed Solution
Additional Context
No response
Screenshots and Recordings
No response