Maintenance: Remove unreachable code (duplicated return statements) (#896)

vil02 · web-flow · commit 178eae817c7a · 2026-04-03T07:12:05.000-07:00
This change removes unreachable `return` statements.

Signed-off-by: vil02 &lt;65706193+vil02@users.noreply.github.com&gt;
diff --git a/src/nvector/raja/nvector_raja.cpp b/src/nvector/raja/nvector_raja.cpp
@@ -1858,7 +1858,6 @@ static int FusedBuffer_CopyPtrArray1D(N_Vector v, N_Vector* X, int nvec,
     SUNDIALS_DEBUG_PRINT("ERROR in FusedBuffer_CopyPtrArray1D: Buffer offset "
                          "is exceedes the buffer size\n");
     return SUN_ERR_GENERIC;
-    return SUN_ERR_GENERIC;
   }
 
   sunrealtype** h_buffer = (sunrealtype**)((char*)(vcp->fused_buffer_host->ptr) +
diff --git a/src/nvector/sycl/nvector_sycl.cpp b/src/nvector/sycl/nvector_sycl.cpp
@@ -2307,7 +2307,6 @@ static int FusedBuffer_CopyPtrArray1D(N_Vector v, N_Vector* X, int nvec,
     SUNDIALS_DEBUG_PRINT("ERROR in FusedBuffer_CopyPtrArray1D: Buffer offset "
                          "is exceedes the buffer size\n");
     return SUN_ERR_GENERIC;
-    return SUN_ERR_GENERIC;
   }
 
   sunrealtype** h_buffer = reinterpret_cast<sunrealtype**>(

Original file line number	Diff line number	Diff line change
`@@ -1858,7 +1858,6 @@ static int FusedBuffer_CopyPtrArray1D(N_Vector v, N_Vector* X, int nvec,`
`1858`	`1858`	`SUNDIALS_DEBUG_PRINT("ERROR in FusedBuffer_CopyPtrArray1D: Buffer offset "`
`1859`	`1859`	`"is exceedes the buffer size\n");`
`1860`	`1860`	`return SUN_ERR_GENERIC;`
`1861`		`- return SUN_ERR_GENERIC;`
`1862`	`1861`	`}`
`1863`	`1862`
`1864`	`1863`	`sunrealtype h_buffer = (sunrealtype)((char*)(vcp->fused_buffer_host->ptr) +`
Original file line number	Diff line number	Diff line change
`@@ -2307,7 +2307,6 @@ static int FusedBuffer_CopyPtrArray1D(N_Vector v, N_Vector* X, int nvec,`
`2307`	`2307`	`SUNDIALS_DEBUG_PRINT("ERROR in FusedBuffer_CopyPtrArray1D: Buffer offset "`
`2308`	`2308`	`"is exceedes the buffer size\n");`
`2309`	`2309`	`return SUN_ERR_GENERIC;`
`2310`		`- return SUN_ERR_GENERIC;`
`2311`	`2310`	`}`
`2312`	`2311`
`2313`	`2312`	`sunrealtype h_buffer = reinterpret_cast<sunrealtype>(`