I think the desktop notifications are better for now than the nextcloud notifications as a first step.

The nextcloud notifications would have the benefit that all devices get the notification and the original does not need to be online. I am thinking of a slow cooking fish which takes hours or even days. Your tablet/computer will not run all the time without closing the page. I would postpone that however for now. It will Twitter also a new API backend. We could also ask in a poll if this feature was even considered helpful.

Regarding the desktop notifications, i think it makes sense to encapsulate things in its own js file. There is already a stub pre-implemented in

Lines 128 to 149 in a96c973

    
           function notify(title, options) { 
        
               if (!("Notification" in window)) { 
        
                   return 
        
               } 
        
               if (Notification.permission === "granted") { 
        
                   // eslint-disable-next-line no-unused-vars 
        
                   const notification = new Notification(title, options) 
        
               } else if (Notification.permission !== "denied") { 
        
                   Notification.requestPermission((permission) => { 
        
                       if (!("permission" in Notification)) { 
        
                           Notification.permission = permission 
        
                       } 
        
                       if (permission === "granted") { 
        
                           // eslint-disable-next-line no-unused-vars 
        
                           const notification = new Notification(title, options) 
        
                       } else { 
        
                           // eslint-disable-next-line no-alert 
        
                           alert(title) 
        
                       } 
        
                   }) 
        
               } 
        
           }

. you can add further files there for simpler code structure 😉.

	function notify(title, options) {
	if (!("Notification" in window)) {
	return
	}
	if (Notification.permission === "granted") {
	// eslint-disable-next-line no-unused-vars
	const notification = new Notification(title, options)
	} else if (Notification.permission !== "denied") {
	Notification.requestPermission((permission) => {
	if (!("permission" in Notification)) {
	Notification.permission = permission
	}
	if (permission === "granted") {
	// eslint-disable-next-line no-unused-vars
	const notification = new Notification(title, options)
	} else {
	// eslint-disable-next-line no-alert
	alert(title)
	}
	})
	}
	}

Add notification support to timers #1064

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions