Skip to content

Commit fec3753

Browse files
authored
feat: 1.0 flagd core transitive deps (#1755)
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
1 parent 63aa60d commit fec3753

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/release-please.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,11 @@ jobs:
6565
# This means there's no way to skip publishing of a particular module in a multi-module build, so we iterate over each module and publish them individually,
6666
# letting exists-maven-plugin skip the nexus-staging-maven-plugin's entire deploy goal if the artifact exists.
6767
run: |
68-
FLAGD_CORE_VERSION=$(cat tools/flagd-core/version.txt)
6968
mvn --non-recursive --batch-mode --settings release/m2-settings.xml -DskipTests -Dcheckstyle.skip clean deploy
7069
modules=($(cat pom.xml | grep "<module>" | sed 's/\s*<.*>\(.*\)<.*>/\1/'))
7170
for module in "${modules[@]}"
7271
do
73-
mvn --batch-mode --projects $module --settings release/m2-settings.xml -DskipTests -Dcheckstyle.skip -Dflagd-core.version=$FLAGD_CORE_VERSION clean deploy
72+
mvn --batch-mode --projects $module --settings release/m2-settings.xml -DskipTests -Dcheckstyle.skip clean deploy
7473
done
7574
env:
7675
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}

providers/flagd/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
<!-- caution - updating this will break compatibility with older protobuf-java versions -->
2121
<protobuf-java.min.version>3.25.6</protobuf-java.min.version>
2222
<com.vmlens.version>1.2.27</com.vmlens.version>
23-
<!-- Match any core version locally- at release, CI sets exact version: -Dflagd-core.version=$(cat tools/flagd-core/version.txt) -->
24-
<flagd-core.version>[0.0.1,)</flagd-core.version>
23+
<!-- Transitive flagd-core version -->
24+
<flagd-core.version>0.2.0</flagd-core.version>
2525
</properties>
2626

2727
<name>flagd</name>

release-please-config.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@
160160
"tools/flagd-api": {
161161
"package-name": "dev.openfeature.contrib.tools.flagdapi",
162162
"release-type": "simple",
163+
"release-as": "1.0.0",
163164
"bump-minor-pre-major": true,
164165
"bump-patch-for-minor-pre-major": true,
165166
"versioning": "default",
@@ -171,6 +172,7 @@
171172
"tools/flagd-core": {
172173
"package-name": "dev.openfeature.contrib.tools.flagdcore",
173174
"release-type": "simple",
175+
"release-as": "1.0.0",
174176
"bump-minor-pre-major": true,
175177
"bump-patch-for-minor-pre-major": true,
176178
"versioning": "default",

tools/flagd-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<artifactId>flagd-api</artifactId>
1313
<version>0.1.0</version> <!--x-release-please-version -->
1414

15-
<properties>
15+
<properties>
1616
<module-name>${groupId}.flagdapi</module-name>
1717
</properties>
1818

0 commit comments

Comments
 (0)