fix: Prevent providers from being shutdown multiple times

If a provider is set for two different domains, and then one of them is
replaced, it will only be shutdown once. However, if a customer were to
use a provider as both default and domain specific, replacing one or the
other would incorrectly shutdown both usages.

Signed-off-by: Matthew Keeler <mkeeler@launchdarkly.com>

Author: keelerm84

openfeature/provider/_registry.py

@@ -30,7 +30,10 @@ def set_provider(self, domain: str, provider: FeatureProvider) -> None:
         if domain in providers:
             old_provider = providers[domain]
             del providers[domain]
-            if old_provider not in providers.values():
+            if (
+                old_provider not in providers.values()
+                and old_provider != self._default_provider
+            ):
                 self._shutdown_provider(old_provider)
         if provider not in providers.values() and provider != self._default_provider:
             self._initialize_provider(provider)
@@ -44,7 +47,10 @@ def get_provider(self, domain: str | None) -> FeatureProvider:
     def set_default_provider(self, provider: FeatureProvider) -> None:
         if provider is None:
             raise GeneralError(error_message="No provider")
-        if self._default_provider:
+        if (
+            self._default_provider
+            and self._default_provider not in self._providers.values()
+        ):
             self._shutdown_provider(self._default_provider)
         self._default_provider = provider
 

tests/provider/test_registry.py

@@ -140,3 +140,35 @@ def test_registering_provider_as_domain_then_default_only_initializes_once():
     registry.set_default_provider(provider)
 
     provider.initialize.assert_called_once()
+
+
+def test_replacing_provider_used_as_default_does_not_shutdown():
+    """Test that replacing a provider that is also the default does not shut it down twice."""
+
+    registry = ProviderRegistry()
+    provider1 = Mock()
+    provider2 = Mock()
+
+    registry.set_default_provider(provider1)
+    registry.set_provider("domain", provider1)
+
+    registry.set_provider("domain", provider2)
+
+    provider1.shutdown.assert_not_called()
+    provider2.shutdown.assert_not_called()
+
+
+def test_replacing_default_provider_used_as_domain_does_not_shutdown():
+    """Test that replacing a default provider that is also used for a domain does not shut it down twice."""
+
+    registry = ProviderRegistry()
+    provider1 = Mock()
+    provider2 = Mock()
+
+    registry.set_provider("domain", provider1)
+    registry.set_default_provider(provider1)
+
+    registry.set_default_provider(provider2)
+
+    provider1.shutdown.assert_not_called()
+    provider2.shutdown.assert_not_called()