Skip to content

monitor-installer: fetch config templates from the local repo instead of curling master #645

@kojiromike

Description

@kojiromike

utilities/openemr-monitor/monitor-installer ships alongside its own config templates (alertmanager.yml, prometheus.yml, dashboard*.yml, docker-compose.yml, etc.) in the same directory — but the installer curls those same files from raw.githubusercontent.com/openemr/openemr-devops/master/... rather than reading the ones sitting next to it.

Consequences:

  • Requires network access to run (and specifically access to GitHub raw).
  • Pins implicitly to whatever master has, regardless of which tag/branch of the repo the user checked out.
  • A user modifying a local template would see their change ignored.

The installer should copy the adjacent templates into ${installDir}, e.g. resolving them relative to $(dirname "$(readlink -f "$0")").

Surfaced in review of #643.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions