Prettier not formatting typescript file

[aoshi321]

Hi

I have the following setting

(add-hook 'typescript-mode-hook 'prettier-js-mode)

but on save nothing happens.

thanks

[soophoo]

I have same issue, @aoshi321 you can fix that by adding a after-save-hook on your typescript emacs config.
Example :

(use-package typescript-mode
  :straight t
  :mode ("\\.tsx?\\'" . typescript-mode)
  :config
  (setq typescript-indent-level 2)
  (add-hook 'flycheck-mode-hook #'sopho/use-eslint-from-node-modules)
  (add-hook 'after-after-hook #'prettier-js-mode)) ; format file with prettier on save

(use-package prettier-js
  :straight t
  :commands (prettier-js-mode prettier-js)
  :hook ((typescript-mode . prettier-js-mode)))

[jacksonrayhamilton]

Hi guys, sorry no one was able to get back to you in the long time since you asked for help here.

I'm not able to reproduce the issue unfortunately. I've tried saving with typescript-mode as well as the built-in typescript-ts-mode and it works for me in both cases.

Using after-save-hook doesn't seem ideal to me. You'll probably want to have prettier-js-mode enabled before you save, otherwise you'd need to save twice the first time to get it to format.

I'm not sure why this happens for some people, but maybe it's due to a conflicting plugin. However I have Tide, FlyCheck, ElDoc, and Company all running alongside prettier-js-mode and they don't seem to conflict with it for me.

I think I would need more information about your config to figure out the cause. You might be able to find a solution by disabling other features in your Emacs config until Prettier starts working.

It may also be that there's an error that this package is completely swallowing, in which case it would be helpful if anyone who runs into this could help me with debugging it.