Skip to content

Commit 785db92

Browse files
authored
ENG-9809: Make sign in button reditect to login (#6664)
1 parent 9378594 commit 785db92

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

packages/reflex-site-shared/src/reflex_site_shared/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
REFLEX_ASSETS_CDN = "https://web.reflex-assets.dev/"
1212
SCREENSHOT_BUCKET = "https://pub-c14a5dcf674640a6b73fded32bad72ca.r2.dev/"
1313
REFLEX_BUILD_URL = os.getenv("REFLEX_BUILD_URL", "https://build.reflex.dev/")
14+
REFLEX_BUILD_LOGIN_URL = f"{REFLEX_BUILD_URL.rstrip('/')}/login"
1415
PIP_URL = "https://pypi.org/project/reflex"
1516
GITHUB_URL = "https://github.com/reflex-dev/reflex"
1617
LINKEDIN_URL = "https://www.linkedin.com/company/reflex-dev"

packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
GITHUB_STARS,
1414
GITHUB_URL,
1515
REFLEX_ASSETS_CDN,
16+
REFLEX_BUILD_LOGIN_URL,
1617
REFLEX_BUILD_URL,
1718
)
1819
from reflex_site_shared.views.sidebar import navbar_sidebar_button
@@ -772,23 +773,22 @@ def navigation_menu() -> rx.Component:
772773
variant="outline",
773774
native_button=False,
774775
),
775-
href=REFLEX_BUILD_URL,
776+
href=REFLEX_BUILD_LOGIN_URL,
776777
target="_blank",
777778
),
778-
class_name="xl:flex hidden",
779779
custom_attrs={"role": "menuitem"},
780780
),
781781
ui.navigation_menu.item(
782782
demo_form_dialog(
783783
trigger=marketing_button(
784-
rx.el.span("Book a Demo", class_name="max-xl:hidden"),
785-
rx.el.span("Demo", class_name="xl:hidden"),
784+
"Book a Demo",
786785
size="sm",
787786
variant="primary",
788787
class_name="whitespace-nowrap",
789788
native_button=False,
790789
),
791790
),
791+
class_name="max-xl:hidden",
792792
unstyled=True,
793793
custom_attrs={"role": "menuitem"},
794794
),

packages/reflex-site-shared/src/reflex_site_shared/views/sidebar/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
CHANGELOG_URL,
1212
DISCORD_URL,
1313
GITHUB_URL,
14+
REFLEX_BUILD_LOGIN_URL,
1415
REFLEX_BUILD_URL,
1516
)
1617
from reflex_site_shared.views.hosting_banner import HostingBannerState
@@ -425,7 +426,7 @@ def drawer_footer() -> rx.Component:
425426
native_button=False,
426427
class_name="w-full",
427428
),
428-
href=REFLEX_BUILD_URL,
429+
href=REFLEX_BUILD_LOGIN_URL,
429430
target="_blank",
430431
class_name="block w-full",
431432
),

0 commit comments

Comments
 (0)