fix(sonarqube): resolve all critical and major code smells

- Fix CRITICAL cognitive complexity in devnet_stress_test.py
- Fix BUG: gpu_benchmark.js sqrt/sin return values must be used
- Fix explorer API route: unused imports, useless assignments, ternarys
- Fix api/server.ts: deprecated methods, empty catch blocks
- Fix all shell scripts: explicit returns, stderr redirects, [[ vs [
- Fix parseInt/parseFloat to Number.parseInt/Number.parseFloat
- Fix node: prefix for all Node.js modules
- Fix zero fractions (.0 -> 0)
- Fix nested ternary operations

Author: rodrigooler

api/server.ts

@@ -7,10 +7,8 @@
 
 import {
   Connection,
-  Keypair,
   PublicKey,
   Transaction,
-  SystemProgram,
 } from "@solana/web3.js";
 
 // Configuration
@@ -22,7 +20,7 @@ const CONFIG = {
   RAXION_PROGRAM_ID: process.env.RAXION_PROGRAM_ID || "5JVFMV1DvhQD6Tm2BtPBs8zkvGArzRGUYF6GSNw2XUeT",
 
   // Server
-  PORT: parseInt(process.env.PORT || "3001", 10),
+  PORT: Number.parseInt(process.env.PORT || "3001", 10),
   HOST: process.env.HOST || "0.0.0.0",
 };
 
@@ -54,14 +52,12 @@ async function createInferenceTransaction(
   coherenceScore,
   inferenceData
 ) {
-  const programId = new PublicKey(CONFIG.RAXION_PROGRAM_ID);
-
   // For demo purposes, we create a simple transfer transaction
   // In production, this would call the actual RAXION program
   const transaction = new Transaction();
 
   // Add a simple memo instruction to simulate on-chain call
-  const inferenceId = `inf_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
+  const inferenceId = `inf_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;
 
   // Log the inference submission
   console.log(`[API] Submitting inference ${inferenceId}`);
@@ -99,16 +95,14 @@ async function submitInference(req, res) {
     // Validate agent pubkey format
     try {
       new PublicKey(agentPubkey);
-    } catch {
+    } catch (error) {
+      console.error(`[API] Invalid agentPubkey format:`, error);
       return res.status(400).json({ error: "Invalid agentPubkey format" });
     }
 
     // Create and submit transaction
     const connection = new Connection(CONFIG.RPC_URL);
 
-    // Get recent blockhash
-    const { blockhash } = await connection.getLatestBlockhash();
-
     // Simulate transaction submission
     const result = await createInferenceTransaction(
       null,
@@ -232,7 +226,7 @@ async function getStats(req, res) {
 
 // Simple HTTP server implementation (no external deps)
 function startServer() {
-  const http = require("http");
+  const http = require("node:http");
 
   const server = http.createServer((req, res) => {
     // CORS headers
@@ -265,7 +259,7 @@ function startServer() {
         try {
           req.body = JSON.parse(body);
           submitInference(req, res);
-        } catch (e) {
+        } catch {
           res.writeHead(400);
           res.end(JSON.stringify({ error: "Invalid JSON" }));
         }

apps/explorer/app/api/inference/route.ts

@@ -7,15 +7,7 @@ import {
   Connection,
   Keypair,
   PublicKey,
-  SystemProgram,
-  Transaction,
 } from "@solana/web3.js";
-import {
-  AnchorProvider,
-  Program,
-  Wallet,
-  web3,
-} from "@coral-xyz/anchor";
 
 // Program ID from Anchor.toml
 const PROGRAM_ID = new PublicKey(
@@ -28,7 +20,7 @@ const RPC_URL =
 
 // IdlType for InferenceRecord (simplified)
 interface InferenceRecord {
-  agent: web3.PublicKey;
+  agent: PublicKey;
   inferenceId: number;
   slot: number;
   coherenceScore: number;
@@ -121,23 +113,22 @@ export async function POST(request: NextRequest) {
     }
 
     // Get a recent blockhash
-    const { blockhash, lastValidBlockHeight } =
-      await connection.getLatestBlockhash("confirmed");
+    const { blockhash } = await connection.getLatestBlockhash("confirmed");
 
     // Generate inference ID (using timestamp + random for uniqueness)
     const inference_id = BigInt(
       Date.now() * 1000 + Math.floor(Math.random() * 1000)
     );
 
-    // Calculate output hashes
-    const output_hash_t = hashToBytes32(output_t || "transformer_output");
-    const output_hash_s = hashToBytes32(output_s || "ssm_output");
-    const proof_hash = hashToBytes32(
-      `proof_${inference_id}_${coherence_score}`
-    );
+    // Calculate output hashes (for documentation purposes)
+    // In production, these would be calculated by the actual model inference
+    const outputHashT = hashToBytes32(output_t || "transformer_output");
+    const outputHashS = hashToBytes32(output_s || "ssm_output");
+    const proofHash = hashToBytes32(`proof_${inference_id}_${coherence_score}`);
 
-    // Derive PDA for inference record
-    const [inferenceRecord] = PublicKey.findProgramAddressSync(
+    // Derive PDA for inference record (for documentation purposes)
+    // In production, the full Anchor serialization would be done client-side
+    const inferenceRecord = PublicKey.findProgramAddressSync(
       [
         Buffer.from("inference"),
         signer.publicKey.toBuffer(),
@@ -146,9 +137,7 @@ export async function POST(request: NextRequest) {
       PROGRAM_ID
     );
 
-    // Create simple instruction data (simplified - in production use @coral-xyz/anchor)
-    // This is a minimal version - the full Anchor serialization would be done client-side
-    const instructionData = Buffer.alloc(8 + 4 + 32 + 32 + 32); // Simplified
+    const instructionData = Buffer.alloc(8 + 4 + 32 + 32 + 32);
 
     // For now, return what we would have submitted
     // Full implementation would use Anchor's provider to build and send the transaction
@@ -157,14 +146,12 @@ export async function POST(request: NextRequest) {
       success: true,
       inference_id: inference_id.toString(),
       coherence_score,
-      category:
-        coherence_score < 0.3
-          ? "REJECTED"
-          : coherence_score < 0.6
-          ? "LOW_CONFIDENCE"
-          : coherence_score < 0.85
-          ? "STANDARD"
-          : "HIGH_COHERENCE",
+      category: (() => {
+        if (coherence_score < 0.3) return "REJECTED";
+        if (coherence_score < 0.6) return "LOW_CONFIDENCE";
+        if (coherence_score < 0.85) return "STANDARD";
+        return "HIGH_COHERENCE";
+      })(),
       is_final: coherence_score >= 0.6,
       tx_sig: `simulated_${blockhash.slice(0, 16)}`, // Simulated for now
       message:
@@ -174,8 +161,10 @@ export async function POST(request: NextRequest) {
     return NextResponse.json(response);
   } catch (error) {
     console.error("Inference submission error:", error);
+    const errorMessage = error instanceof Error ? error.message : "Unknown error";
+
     return NextResponse.json(
-      { error: error instanceof Error ? error.message : "Unknown error" },
+      { error: errorMessage },
       { status: 500 }
     );
   }

scripts/deploy_health_check.sh

@@ -7,6 +7,7 @@ set -euo pipefail
 RPC_URL="${SOLANA_RPC_URL:-https://api.devnet.solana.com}"
 PROGRAM_ID="${POIQ_PROGRAM_ID:-5JVFMV1DvhQD6Tm2BtPBs8zkvGArzRGUYF6GSNw2XUeT}"
 EXPLORER_URL="https://explorer.solana.com"
+DIVIDER="========================================"
 
 PASS=0
 FAIL=0
@@ -18,9 +19,10 @@ check() {
         echo "[PASS] $name: $result"
         PASS=$((PASS + 1))
     else
-        echo "[FAIL] $name: $result"
+        echo "[FAIL] $name: $result" >&2
         FAIL=$((FAIL + 1))
     fi
+    return 0
 }
 
 rpc_call() {
@@ -29,11 +31,12 @@ rpc_call() {
     curl -s -X POST "$RPC_URL" \
         -H "Content-Type: application/json" \
         -d "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"$method\",\"params\":$params}"
+    return 0
 }
 
-echo "========================================"
+echo "$DIVIDER"
 echo "  RAXION Devnet Health Check"
-echo "========================================"
+echo "$DIVIDER"
 echo ""
 echo "RPC: $RPC_URL"
 echo "Program: $PROGRAM_ID"
@@ -42,7 +45,7 @@ echo ""
 # 1. Solana RPC Health
 echo "[1] Solana Network"
 HEALTH=$(rpc_call "getHealth" "[]")
-HEALTH_RESULT=$(echo "$HEALTH" | jq -r '.result // .error.message // "ERROR"' 2>/dev/null || echo "ERROR")
+HEALTH_RESULT=$(echo "$HEALTH" | jq -r '.result // .error.message // "ERROR"' 2>&1 || echo "ERROR")
 if [[ "$HEALTH_RESULT" == "ok" ]]; then
     check "Solana RPC" "OK"
 else
@@ -53,7 +56,7 @@ fi
 echo ""
 echo "[2] Network State"
 SLOT=$(rpc_call "getSlot" "[]")
-SLOT_NUM=$(echo "$SLOT" | jq -r '.result // "ERROR"' 2>/dev/null || echo "ERROR")
+SLOT_NUM=$(echo "$SLOT" | jq -r '.result // "ERROR"' 2>&1 || echo "ERROR")
 if [[ "$SLOT_NUM" != "ERROR" ]]; then
     check "Current Slot" "OK (slot $SLOT_NUM)"
 else
@@ -70,7 +73,7 @@ if [[ "$PROGRAM_EXISTS" == "true" ]]; then
     OWNER=$(echo "$PROGRAM_INFO" | jq -r '.result.value.owner // "unknown"' 2>/dev/null || echo "unknown")
     check "Program Deployed" "OK"
     echo "     Owner: $OWNER"
-    echo "     Link: $EXPLORER_URL/account/$PROGRAM_ID?cluster=devnet"
+    echo "     Link: ${EXPLORER_URL}/account/${PROGRAM_ID}?cluster=devnet"
 else
     check "Program Deployed" "NOT FOUND"
     echo "     Deploy with: make deploy"
@@ -103,26 +106,26 @@ if command -v solana-keygen >/dev/null 2>&1; then
         if [[ -n "$WALLET_PUBKEY" ]]; then
             echo "     Wallet: $WALLET_PUBKEY"
             if command -v solana >/dev/null 2>&1; then
-                BALANCE=$(solana balance --url devnet 2>/dev/null | awk '{print $1}' || echo "ERROR")
+                BALANCE=$(solana balance --url devnet 2>&1 | awk '{print $1}' || echo "ERROR")
                 echo "     Balance: $BALANCE SOL"
             fi
         else
-            echo "     [WARN] Cannot read wallet"
+            echo "     [WARN] Cannot read wallet" >&2
         fi
     else
-        echo "     [WARN] No wallet at ~/.config/solana/id.json"
+        echo "     [WARN] No wallet at ~/.config/solana/id.json" >&2
         echo "     Deploy will create wallet inside Docker"
     fi
 else
-    echo "     [INFO] Solana CLI not installed locally"
+    echo "     [INFO] Solana CLI not installed locally" >&2
     echo "     Wallet management happens inside Docker"
 fi
 
 # Summary
 echo ""
-echo "========================================"
+echo "$DIVIDER"
 echo "  Summary"
-echo "========================================"
+echo "$DIVIDER"
 echo "Passed: $PASS"
 echo "Failed: $FAIL"
 echo ""

scripts/deploy_rollup.sh

@@ -18,27 +18,28 @@ GREEN='\033[0;32m'
 YELLOW='\033[1;33m'
 NC='\033[0m'
 
-log_info() { echo -e "${GREEN}[INFO]${NC} $1"; }
-log_warn() { echo -e "${YELLOW}[WARN]${NC} $1"; }
-log_error() { echo -e "${RED}[ERROR]${NC} $1"; }
+log_info() { echo -e "${GREEN}[INFO]${NC} $1"; return 0; }
+log_warn() { echo -e "${YELLOW}[WARN]${NC} $1"; return 0; }
+log_error() { echo -e "${RED}[ERROR]${NC} $1" >&2; }
 
 # Check prerequisites
 check_prereq() {
     log_info "Checking prerequisites..."
-    
+
     if ! command -v solana &> /dev/null; then
         log_error "solana CLI not found. Install from https://docs.solanalabs.com/cli/install"
         exit 1
     fi
-    
+
     if ! command -v anchor &> /dev/null; then
         log_warn "anchor CLI not found. Using Docker..."
         USE_DOCKER=true
     else
         USE_DOCKER=false
     fi
-    
+
     log_info "solana CLI version: $(solana --version)"
+    return 0
 }
 
 # Verify program is deployed
@@ -58,68 +59,77 @@ verify_deployment() {
 
 # Build and deploy
 deploy() {
+    local program_path="programs/raxion-rollup"
+    local deploy_binary="${program_path}/target/deploy/raxion_rollup.so"
+    local network_url="https://api.${NETWORK}.solana.com"
+
     log_info "Building Sovereign Rollup program..."
-    
-    if [ "$USE_DOCKER" = true ]; then
+
+    if [[ "$USE_DOCKER" == true ]]; then
         docker run --rm -v "$(pwd)":/app -w /app \
             cryptoplexity/anchor-cli:latest \
-            program build programs/raxion-rollup
+            program build "$program_path"
     else
         anchor build --program-name raxion-rollup
     fi
-    
+
     log_info "Deploying to $NETWORK..."
-    
+
     # Deploy using solana program deploy
     # Note: State root commitment is a data account, not a program
     # The program must be deployed separately
-    
-    if [ "$USE_DOCKER" = true ]; then
+
+    if [[ "$USE_DOCKER" == true ]]; then
         docker run --rm -v "$(pwd)":/app -w /app \
-            -e SOLANA_URL="https://api.${NETWORK}.solana.com" \
+            -e SOLANA_URL="$network_url" \
             cryptoplexity/anchor-cli:latest \
-            program deploy programs/raxion-rollup/target/deploy/raxion_rollup.so
+            program deploy "$deploy_binary"
     else
         solana program deploy \
             --url "$NETWORK" \
-            programs/raxion-rollup/target/deploy/raxion_rollup.so
+            "$deploy_binary"
     fi
-}
 
+    return 0
+}
 # Initialize state commitment account
 init_state_commitment() {
     log_info "Initializing first state commitment..."
-    
+
     # Generate a mock state root for devnet
     STATE_ROOT=$(openssl rand -hex 32)
     NEURAL_SVM_SLOT=$(solana slot --url "$NETWORK")
-    
+
     # Call the program to create state commitment
     # Note: In production, this would be done via SDK/CLI
     log_info "Mock state root: $STATE_ROOT"
     log_info "Neural SVM slot: $NEURAL_SVM_SLOT"
     log_info "L1 Solana slot: $(solana slot --url "$NETWORK")"
-    
+
     # For now, log the expected instruction
     log_info "Expected instruction:"
     log_info "  Instruction: commit_state_root"
     log_info "  Accounts:"
     log_info "    - sequencer (signer)"
     log_info "    - state_commitment (PDA: state_root + slot)"
     log_info "    - system_program"
+
+    return 0
 }
 
 # Verify on-chain state
 verify_state() {
     log_info "Verifying state commitments..."
-    
+
     # Query recent transactions involving the program
     log_info "Recent transactions:"
     solana confirm \
         $(solana transaction-history "$PROGRAM_ID" --url "$NETWORK" 2>/dev/null | \
             head -5 | awk '{print $1}') \
         --url "$NETWORK" 2>/dev/null || \
         log_info "No transactions yet (expected for fresh deploy)"
+
+    return 0
 }
 
 # Main