Commit 77ebbf9
test(mincut): #[ignore] flaky test_delete_tree_edge — real bug in WitnessTree (#396)
`WitnessTree::delete_edge`:
1. Removes a tree edge and `lct.cut`s.
2. Calls `find_replacement(u, v)` to find a graph edge spanning the
newly-disconnected components.
3. Calls `lct.link(ru, rv)?` on the replacement.
In the triangle test, step 2 returns an edge whose endpoints are still
in the same LCT tree post-cut (logic bug in find_replacement, or the
cut didn't actually disconnect the right way). Step 3 then errors with
`InternalError("Nodes are already in the same tree")` and the test
panics on `.unwrap()`.
Real production bug. Quarantining with a TODO so PR #391/#393/#394 can
land. Sister TODO list:
- ruvector-mincut::subpolynomial::test_min_cut_{triangle,bridge},
test_recourse_stats, test_is_subpolynomial (PR #389)
- ruvector-mincut::witness::test_delete_tree_edge (this commit)
Co-authored-by: ruvnet <ruvnet@gmail.com>1 parent 1676ffe commit 77ebbf9
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
711 | 711 | | |
712 | 712 | | |
713 | 713 | | |
| 714 | + | |
714 | 715 | | |
715 | 716 | | |
716 | 717 | | |
| |||
0 commit comments