SF-3772 Prevent duplicate onboarding requests

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-request-detail.component.ts

@@ -29,10 +29,10 @@ import { JsonViewerComponent } from '../shared/json-viewer/json-viewer.component
 import { MobileNotSupportedComponent } from '../shared/mobile-not-supported/mobile-not-supported.component';
 import { projectLabel } from '../shared/utils';
 import {
-  DraftingSignupFormData,
   DraftRequestResolutionKey,
   DraftRequestResolutionMetadata,
   OnboardingRequest,
+  OnboardingRequestFormData,
   OnboardingRequestService
 } from '../translate/draft-generation/onboarding-request.service';
 import { ServalAdministrationService } from './serval-administration.service';
@@ -225,7 +225,7 @@ export class DraftRequestDetailComponent extends DataLoadingComponent implements
 
   getStatus = this.onboardingRequestService.getStatus;
 
-  get formData(): DraftingSignupFormData {
+  get formData(): OnboardingRequestFormData {
     return this.request!.submission.formData;
   }
 

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.ts

@@ -17,6 +17,7 @@ import { User } from 'realtime-server/lib/esm/common/models/user';
 import { DevOnlyComponent } from 'src/app/shared/dev-only/dev-only.component';
 import { ActivatedProjectService } from 'xforge-common/activated-project.service';
 import { DataLoadingComponent } from 'xforge-common/data-loading-component';
+import { DialogService } from 'xforge-common/dialog.service';
 import { I18nService } from 'xforge-common/i18n.service';
 import { NoticeService } from 'xforge-common/notice.service';
 import { UserService } from 'xforge-common/user.service';
@@ -28,7 +29,7 @@ import { ProjectSelectComponent } from '../../../project-select/project-select.c
 import { BookMultiSelectComponent } from '../../../shared/book-multi-select/book-multi-select.component';
 import { JsonViewerComponent } from '../../../shared/json-viewer/json-viewer.component';
 import { compareProjectsForSorting, projectLabel } from '../../../shared/utils';
-import { DraftingSignupFormData, OnboardingRequestService } from '../onboarding-request.service';
+import { OnboardingRequestFormData, OnboardingRequestService } from '../onboarding-request.service';
 
 export const DRAFT_SIGNUP_RESPONSE_DAYS = { min: 1, max: 3 } as const;
 
@@ -135,8 +136,9 @@ export class DraftOnboardingFormComponent extends DataLoadingComponent implement
     private readonly activatedProject: ActivatedProjectService,
     private readonly userService: UserService,
     private readonly paratextService: ParatextService,
-    private readonly draftingSignupService: OnboardingRequestService,
+    private readonly onboardingRequestService: OnboardingRequestService,
     protected readonly noticeService: NoticeService,
+    protected readonly dialogService: DialogService,
     private readonly destroyRef: DestroyRef,
     private readonly cd: ChangeDetectorRef,
     private readonly i18n: I18nService
@@ -147,6 +149,8 @@ export class DraftOnboardingFormComponent extends DataLoadingComponent implement
   ngOnInit(): void {
     this.loadingStarted();
 
+    void this.checkAndWarnIfAlreadySubmitted();
+
     // Get the current user and pre-fill the form
     this.userService
       .getCurrentUser()
@@ -204,9 +208,9 @@ export class DraftOnboardingFormComponent extends DataLoadingComponent implement
   }
 
   async onSubmit(): Promise<void> {
-    if (this.uiState === 'submitting') {
-      return;
-    }
+    if (this.uiState === 'submitting') return;
+
+    if (await this.checkAndWarnIfAlreadySubmitted()) return;
 
     if (this.signupForm.valid === true) {
       if (this.activatedProject.projectId == null) {
@@ -217,10 +221,10 @@ export class DraftOnboardingFormComponent extends DataLoadingComponent implement
       this.uiState = 'submitting';
       this.cd.markForCheck();
 
-      const formData: DraftingSignupFormData = this.signupForm.getRawValue() as DraftingSignupFormData;
+      const formData: OnboardingRequestFormData = this.signupForm.getRawValue() as OnboardingRequestFormData;
 
       try {
-        const requestId = await this.draftingSignupService.submitOnboardingRequest(
+        const requestId = await this.onboardingRequestService.submitOnboardingRequest(
           this.activatedProject.projectId,
           formData
         );
@@ -348,6 +352,27 @@ export class DraftOnboardingFormComponent extends DataLoadingComponent implement
     }
   }
 
+  /**
+   * If a request has already been submitted:
+   * - Informs user with a message dialog
+   * - Redirects to drafting page when user closes dialog
+   * - Resolves to true
+   *
+   * Otherwise, resolves to false
+   */
+  private async checkAndWarnIfAlreadySubmitted(): Promise<boolean> {
+    const alreadySubmitted = await this.hasRequestAlreadyBeenSubmitted();
+    if (alreadySubmitted) {
+      await this.dialogService.message('draft_sources.request_already_submitted', undefined, true);
+      this.cancel();
+    }
+    return alreadySubmitted;
+  }
+
+  private async hasRequestAlreadyBeenSubmitted(): Promise<boolean> {
+    return (await this.onboardingRequestService.getOpenOnboardingRequest(this.activatedProject.projectId!)) != null;
+  }
+
   private async loadProjectsAndResources(): Promise<void> {
     try {
       const [projects, resources] = await Promise.all([

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/onboarding-request.service.ts

@@ -10,7 +10,7 @@ export interface DraftRequestComment {
   dateCreated: string;
 }
 
-export interface DraftingSignupFormData {
+export interface OnboardingRequestFormData {
   name: string;
   email: string;
   organization: string;
@@ -44,7 +44,7 @@ export interface OnboardingRequest {
     projectId: string;
     userId: string;
     timestamp: string;
-    formData: DraftingSignupFormData;
+    formData: OnboardingRequestFormData;
   };
   assigneeId: string;
   status: DraftRequestStatusOption;
@@ -105,7 +105,7 @@ export class OnboardingRequestService {
   }
 
   /** Submits a new signup request. */
-  async submitOnboardingRequest(projectId: string, formData: DraftingSignupFormData): Promise<string> {
+  async submitOnboardingRequest(projectId: string, formData: OnboardingRequestFormData): Promise<string> {
     return (await this.onlineInvoke<string>('submitOnboardingRequest', { projectId, formData }))!;
   }
 

src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json

@@ -403,6 +403,7 @@
     "select_project_to_translate": "Select the project to translate.",
     "some_projects_use_back_translation": "Some projects get better results by adding a back translation as another reference.",
     "source_side_language_codes_differ": "All source and reference projects must be in the same language. Please select different source or reference projects.",
+    "request_already_submitted": "A request to activate drafting on this project has already been submitted. Please wait for a response from the team before submitting another request.",
     "state_connecting": "Connecting",
     "state_sync_failed": "There was an error syncing",
     "state_sync_successful": "Sync successful",