Skip to content
This repository was archived by the owner on Aug 28, 2021. It is now read-only.
This repository was archived by the owner on Aug 28, 2021. It is now read-only.

Web sockets getting created during the disposal of a client object. #146

@pablothedolphin

Description

@pablothedolphin

Step 0:

Expected Behaviour

SpeckleApiClient.Dispose () should just dispose the object with no errors.

Actual Behaviour

SpeckleApiClient.Dispose () triggers its onError callback with the event argument name simply being "websocket-disconnected". Still seems to work, but the error is unnecessary.

SpeckleApiClient.SetupWebsocket () is somehow being called when the client object gets disposed. This is regardless of whether or not true or false is passed into the dispose method.

Affected Projects

SpeckleUnity.

Reproduction Steps & System Config (win, osx, web, etc.)

Receive a stream and once it's received, I then try to dispose the client object and get thrown this error.

Proposed Solution (if any)

Try to avoid setting up a new web socket while disposing a client object.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions