Skip to content

Commit aed8ae7

Browse files
committed
🐛(frontend) remove horizontal line when no elements
When no elements are present in the doc share modals, a horizontal line is still displayed. This PR removes this line when there are no elements to display.
1 parent e39b03c commit aed8ae7

3 files changed

Lines changed: 42 additions & 27 deletions

File tree

src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareAccessRequest.tsx

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { createGlobalStyle, css } from 'styled-components';
1111
import {
1212
Box,
1313
BoxButton,
14+
HorizontalSeparator,
1415
Icon,
1516
LoadMoreText,
1617
Loading,
@@ -165,19 +166,25 @@ export const QuickSearchGroupAccessRequest = ({
165166
}
166167

167168
return (
168-
<Box
169-
aria-label={t('List request access card')}
170-
className="--docs--share-access-request"
171-
$padding={{ horizontal: 'base' }}
172-
>
173-
<QuickSearchGroupAccessRequestStyle />
174-
<QuickSearchGroup
175-
group={accessRequestsData}
176-
renderElement={(accessRequest) => (
177-
<DocShareAccessRequestItem doc={doc} accessRequest={accessRequest} />
178-
)}
179-
/>
180-
</Box>
169+
<>
170+
<Box
171+
aria-label={t('List request access card')}
172+
className="--docs--share-access-request"
173+
$padding={{ horizontal: 'base' }}
174+
>
175+
<QuickSearchGroupAccessRequestStyle />
176+
<QuickSearchGroup
177+
group={accessRequestsData}
178+
renderElement={(accessRequest) => (
179+
<DocShareAccessRequestItem
180+
doc={doc}
181+
accessRequest={accessRequest}
182+
/>
183+
)}
184+
/>
185+
</Box>
186+
<HorizontalSeparator $margin={{ vertical: 'sm' }} />
187+
</>
181188
);
182189
};
183190

src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareInvitation.tsx

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@ import { useMemo } from 'react';
66
import { useTranslation } from 'react-i18next';
77
import { css } from 'styled-components';
88

9-
import { Box, BoxButton, Icon, LoadMoreText, Text } from '@/components';
9+
import {
10+
Box,
11+
BoxButton,
12+
HorizontalSeparator,
13+
Icon,
14+
LoadMoreText,
15+
Text,
16+
} from '@/components';
1017
import { QuickSearchData, QuickSearchGroup } from '@/components/quick-search';
1118
import { useCunninghamTheme } from '@/cunningham';
1219
import { Doc, Role } from '@/docs/doc-management';
@@ -162,16 +169,19 @@ export const QuickSearchGroupInvitation = ({
162169
}
163170

164171
return (
165-
<Box
166-
aria-label={t('List invitation card')}
167-
$padding={{ horizontal: 'base' }}
168-
>
169-
<QuickSearchGroup
170-
group={invitationsData}
171-
renderElement={(invitation) => (
172-
<DocShareInvitationItem doc={doc} invitation={invitation} />
173-
)}
174-
/>
175-
</Box>
172+
<>
173+
<Box
174+
aria-label={t('List invitation card')}
175+
$padding={{ horizontal: 'base' }}
176+
>
177+
<QuickSearchGroup
178+
group={invitationsData}
179+
renderElement={(invitation) => (
180+
<DocShareInvitationItem doc={doc} invitation={invitation} />
181+
)}
182+
/>
183+
</Box>
184+
<HorizontalSeparator $margin={{ vertical: 'sm' }} />
185+
</>
176186
);
177187
};

src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareModal.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,9 +291,7 @@ export const DocShareModal = ({ doc, onClose, isRootDoc = true }: Props) => {
291291
{showMemberSection && isRootDoc && (
292292
<Box $padding={{ top: 'base' }}>
293293
<QuickSearchGroupAccessRequest doc={doc} />
294-
<HorizontalSeparator $margin={{ vertical: 'sm' }} />
295294
<QuickSearchGroupInvitation doc={doc} />
296-
<HorizontalSeparator $margin={{ vertical: 'sm' }} />
297295
<QuickSearchGroupMember doc={doc} />
298296
</Box>
299297
)}

0 commit comments

Comments
 (0)