Merge branch 'main' into skip-duplicate-pipelineruns

Author: chmouel

.github/workflows/e2e.yaml

@@ -40,7 +40,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        provider: [providers, gitea_others]
+        provider: [github, github_second_controller, gitlab_bitbucket, gitea_others, concurrency]
 
     env:
       CONTROLLER_DOMAIN_URL: paac.paac-127-0-0-1.nip.io
@@ -292,7 +292,7 @@ jobs:
           nohup gosmee client --saveDir /tmp/gosmee-replay ${{ secrets.TEST_GITEA_SMEEURL }} "https://${CONTROLLER_DOMAIN_URL}" &
 
       - name: Run gosmee for second controller (GHE)
-        if: matrix.provider == 'providers'
+        if: matrix.provider == 'github_second_controller' || matrix.provider == 'concurrency'
         run: |
           nohup gosmee client --saveDir /tmp/gosmee-replay-ghe ${{ secrets.TEST_GITHUB_SECOND_SMEE_URL }} "https://ghe.paac-127-0-0-1.nip.io" &
 

docs/content/docs/dev/_index.md

@@ -396,6 +396,13 @@ When submitting a pull request to Pipelines-as-Code, contributors must disclose
 any AI/LLM assistance used during development. This promotes transparency and
 proper attribution in our collaborative development environment.
 
+### Python dependencies
+
+```shell
+cd ./hack/pr-ci
+uv lock -U
+```
+
 ### Required Disclosure
 
 All contributors must:
@@ -444,47 +451,3 @@ Co-authored-by: Gemini <gemini@google.com>
 
 See the [PR template](.github/pull_request_template.md) for complete details on
 the AI assistance disclosure requirements.
-
-## Testing External contributor Pull Requests for E2E Testing
-
-When an external contributor submits a pull request (PR), E2E tests may not run
-automatically due to security restrictions. To work around this, maintainers
-can use a script to mirror the external PR to their own fork, allowing E2E
-tests to run safely.
-
-### Usage
-
-1. Ensure you have the [GitHub CLI (`gh`)](https://cli.github.com/) installed and authenticated and fzf installed.
-2. Fork the repository and configure your fork as a git remote.
-3. Run the script:
-
-   ```bash
-   ./hack/mirror-pr.sh <PR_NUMBER> <YOUR_FORK_REMOTE>
-   ```
-
-   If you omit the PR number, you'll be prompted to select one interactively.
-   Same for the fork remote, if you omit it, it will get asked with fzf.
-
-### What the Script Does
-
-- Checks out the external PR locally.
-- Pushes the branch to your fork with a unique name.
-- Creates a draft pull request on the upstream repository with a `[MIRRORED] DO NOT MERGE` title and a `do-not-merge` label.
-- Comments on the original PR with a link to the mirrored PR.
-
-This process allows E2E tests to run on the mirrored PR, while preventing accidental merges. Once the original PR is merged, the mirrored PR can be closed.
-
-See the script (`./hack/mirror-pr.sh`) in the repository for details.
-
-### When all is green in the mirrored PR pull request
-
-- You can merge the external contributor original PR.
-- Close the mirrored PR.
-- Cleanup the branches on your fork or on your local repo
-
-# Links
-
-- [Jira Backlog](https://issues.redhat.com/browse/SRVKP-2144?jql=component%20%3D%20%22Pipeline%20as%20Code%22%20%20AND%20status%20!%3D%20Done)
-- [Bitbucket Data Center Rest API](https://docs.atlassian.com/bitbucket-server/rest/7.17.0/bitbucket-rest.html)
-- [GitHub API](https://docs.github.com/en/rest/reference)
-- [GitLab API](https://docs.gitlab.com/ee/api/api_resources.html)

docs/content/docs/dev/release-process.md

@@ -19,31 +19,34 @@ git tag v1.2.3
 * And pushing it directly to the repo (you need access) :
 
 ```shell
-% NOTESTS=ci git push git@github.com:openshift-pipelines/pipelines-as-code refs/tags/1.2.3
+% git push --no-verify git@github.com:openshift-pipelines/pipelines-as-code refs/tags/1.2.3
 ```
 
 * When it started you can follow it on the pac cluster :
 
 `tkn pr logs -n pipelines-as-code-ci -Lf`
 
 * After a while (gorelease takes sometime) If everything is fine you should
-  have the new version set as pre-release in
+  have the new version set as pre-release inside:
+
   <https://github.com/openshift-pipelines/pipelines-as-code/releases>
 
 * Edit the release like the other releases has been done with a snippet of the highlight of the release.
 
-* Announce it on Slack (upstream/downstream)  and twitter.
-
-## Packages
+* If you use AI:
+  * make sure to verify the content as it may contains some mistakes.
+  * don't make it overusing emojis, let's make it professional.
+  * make sure to categorize the changes properly. sometime it would expose
+  internal changes as major features.
 
-* [Arch AUR](https://aur.archlinux.org/packages/tkn-pac): Ping chmouel for an update
+* Announce it on Slack (upstream/downstream) and twitter.
 
-# Issues you may see
+## Packages
 
 * Sometimes, there may be some issues with system or others. If you need to re-kick the release process you need to :
 
 ```shell
-   git tag --sign --force v1.2.3
+   git tag --force v1.2.3
    git push --force git@github.com:openshift-pipelines/pipelines-as-code v1.2.3
 ```
 

hack/gh-workflow-ci.sh

@@ -71,17 +71,33 @@ create_second_github_app_controller_on_ghe() {
 }
 
 get_tests() {
-  target=$1
+  local target="$1"
+  local -a testfiles
+  local all_tests
   mapfile -t testfiles < <(find test/ -maxdepth 1 -name '*.go')
-  ghglabre="Github|Gitlab|Bitbucket"
-  if [[ ${target} == "providers" ]]; then
-    grep -hioP "^func Test.*(${ghglabre})(\w+)\(" "${testfiles[@]}" | sed -e 's/func[ ]*//' -e 's/($//'
-    elif [[ ${target} == "gitea_others" ]]; then
-    grep -hioP '^func Test(\w+)\(' "${testfiles[@]}" | grep -iPv "(${ghglabre})" | sed -e 's/func[ ]*//' -e 's/($//'
-  else
-    echo "Invalid target: ${target}"
-    echo "supported targets: githubgitlab, others"
-  fi
+  all_tests=$(grep -hioP '^func[[:space:]]+Test[[:alnum:]_]+' "${testfiles[@]}" | sed -E 's/^func[[:space:]]+//')
+
+  case "${target}" in
+    concurrency)
+      printf '%s\n' "${all_tests}" | grep -iP 'Concurrency'
+      ;;
+    github)
+      printf '%s\n' "${all_tests}" | grep -iP 'Github' | grep -ivP 'Concurrency|GithubSecond|SecondController'
+      ;;
+    github_second_controller)
+      printf '%s\n' "${all_tests}" | grep -iP 'GithubSecond|SecondController' | grep -ivP 'Concurrency'
+      ;;
+    gitlab_bitbucket)
+      printf '%s\n' "${all_tests}" | grep -iP 'Gitlab|Bitbucket' | grep -ivP 'Concurrency'
+      ;;
+    gitea_others)
+      printf '%s\n' "${all_tests}" | grep -ivP 'Github|Gitlab|Bitbucket|Concurrency'
+      ;;
+    *)
+      echo "Invalid target: ${target}"
+      echo "supported targets: github, github_second_controller, gitlab_bitbucket, gitea_others, concurrency"
+      ;;
+  esac
 }
 
 run_e2e_tests() {

hack/pr-ci/uv.lock

@@ -1,4 +1,11 @@
-#!/usr/bin/env python3
+#!/usr/bin/env -S uv --quiet run --script
+# /// script
+# requires-python = ">=3.12"
+# dependencies = [
+#     "requests",
+#     "PyYAML",
+# ]
+# ///
 # Author: Chmouel Boudjnah <chmouel@redhat.com>
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may

hack/second-controller.py

@@ -128,10 +128,13 @@ Tests run on:
 
 ### Test Categories
 
-The tests are separated into two main categories (matrix strategy):
+The tests are separated into provider categories (matrix strategy):
 
-- `providers` - Tests for GitHub, GitLab, and Bitbucket
-- `gitea_others` - Tests for Gitea and other non-provider specific functionality
+- `github` - GitHub tests (excluding second controller and concurrency)
+- `github_second_controller` - GitHub second controller tests
+- `gitlab_bitbucket` - GitLab and Bitbucket tests
+- `gitea_others` - Gitea and other non-provider specific functionality
+- `concurrency` - Concurrency-specific tests
 
 This split helps reduce the load on external APIs during testing and provides more focused test results.