[RQD] Fix core detection on Windows platforms#1468
Merged
DiegoTavares merged 11 commits intoDec 4, 2024
Merged
Conversation
anton-ubi
force-pushed
the
bug/windows_core_detection
branch
from
9e79b17 to
d8e4190
Compare
anton-ubi
changed the title
anton-ubi
force-pushed
the
bug/windows_core_detection
branch
from
d8e4190 to
ddeb921
Compare
Collaborator
DiegoTavares
left a comment
DiegoTavares
left a comment
There was a problem hiding this comment.
Just minor comments. Everything else looks good to me.
Collaborator
|
Hi @anton-ubi If I'm not mistaken, this is your first contribution. Welcome to the project. Please sign the CLA to get the pipeline unblocked. |
Contributor
Author
Yes it is. Thank you. I'll look into that. |
KernAttila
reviewed
Aug 28, 2024
KernAttila
reviewed
Aug 28, 2024
Co-authored-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com> Signed-off-by: Diego Tavares <dtavares@imageworks.com>
Signed-off-by: Diego Tavares <dtavares@imageworks.com>
Collaborator
|
There are still some lint errors to be fixed before we can merge this PR |
Contributor
|
@anton-ubi I'm in the process of implementing a proper core detection mechanism for Windows without dependency to WMI. |
DiegoTavares
approved these changes
Dec 4, 2024
Contributor
Author
|
[celebrate] Anton Brand reacted to your message:
…________________________________
From: Diego Tavares ***@***.***>
Sent: Wednesday, December 4, 2024 7:07:01 PM
To: AcademySoftwareFoundation/OpenCue ***@***.***>
Cc: Anton Brand ***@***.***>; Mention ***@***.***>
Subject: Re: [AcademySoftwareFoundation/OpenCue] [RQD] Fix core detection on Windows platforms (PR #1468)
Merged #1468<#1468> into master.
—
Reply to this email directly, view it on GitHub<#1468 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDAVROHCNVHCZFVEEOIVYY32D5HFLAVCNFSM6AAAAABMQZ32VWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUZTCMRTGYYDKNQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#1469
Summarize your change.
Fix an error on Windows platforms where a submitted job could not be picked up properly due to available processors incorrect detection.
The
reserveHTmethod of the RQDMachineclass relies on a__procs_by_physid_and_coreidattribute that is not correctly filled when on a Windows platform.See:
reserveHTrelying on__procs_by_physid_and_coreid: https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/rqd/rqd/rqmachine.py#L842__procs_by_physid_and_coreidbeing filled only if on a Linux platform: https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/rqd/rqd/rqmachine.py#L613