Skip to content

[minor][feature]: add Bleu cloud#1726

Open
hieunguyenmsft wants to merge 1 commit into
devfrom
hieund/add_bleu_cloud
Open

[minor][feature]: add Bleu cloud#1726
hieunguyenmsft wants to merge 1 commit into
devfrom
hieund/add_bleu_cloud

Conversation

@hieunguyenmsft

Copy link
Copy Markdown
Contributor

PR Title Format

Required Format: [Keyword1] [Keyword2]: Description

  • Keyword1: major, minor, or patch (case-insensitive)
  • Keyword2: feature, bugfix, engg, or tests (case-insensitive)

Examples:

  • [MAJOR] [Feature]: new API
  • [minor] [bugfix]: fix crash
  • [PATCH][tests]:add coverage

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@@ -40,8 +40,9 @@
s_trustedHostList = [NSSet setWithObjects:MSIDTrustedAuthority,
MSIDTrustedAuthorityUS,
MSIDTrustedAuthorityChina,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for an additional Azure AD authority host (“Bleu”/France sovereign cloud) by introducing a new trusted authority constant and including it in the trusted-host allowlist used for authority validation.

Changes:

  • Add MSIDTrustedAuthorityFrance constant (login.sovcloud-identity.fr).
  • Expose the new constant in MSIDConstants.h.
  • Include the new host in MSIDAADNetworkConfiguration’s s_trustedHostList allowlist.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
IdentityCore/src/MSIDConstants.m Defines the new trusted authority host constant.
IdentityCore/src/MSIDConstants.h Declares the new constant for use across the library.
IdentityCore/src/MSIDAADNetworkConfiguration.m Adds the new host to the trusted host allowlist used by authority “known host” checks.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 40 to 48
s_trustedHostList = [NSSet setWithObjects:MSIDTrustedAuthority,
MSIDTrustedAuthorityUS,
MSIDTrustedAuthorityChina,
MSIDTrustedAuthorityChina2,
MSIDTrustedAuthorityGermany,
MSIDTrustedAuthorityFrance,
MSIDTrustedAuthorityWorldWide,
MSIDTrustedAuthorityUSGovernment,
MSIDTrustedAuthorityCloudGovApi, nil];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants